Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop-rspec 2.14.1 → 3.2.0 (major) #82

Closed
wants to merge 1 commit into from

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Oct 27, 2024

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop-rspec (2.14.1 → 3.2.0) · Repo · Changelog

Release Notes

Too many releases to show here. View the full release notes.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

✳️ rubocop (1.37.1 → 1.67.0) · Repo · Changelog

Release Notes

Too many releases to show here. View the full release notes.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ json (indirect, 2.6.2 → 2.7.4) · Repo · Changelog

Release Notes

2.7.4

What's Changed

  • Workaround a bug in 3.4.8 and older rubygems/rubygems#6490.
    This bug would cause some gems with native extension to fail during compilation.
  • Workaround different versions of json and json_pure being loaded (not officially supported).
  • Make json_pure Ractor compatible.

Full Changelog: ruby/json@v2.7.3...v2.7.4

2.7.3

What's Changed

  • Numerous performance optimizations in JSON.generate and JSON.dump (up to 2 times faster).
  • Limit the size of ParserError exception messages, only include up to 32 bytes of the unparseable source.
  • Fix json-pure's Object#to_json to accept non state arguments
  • Fix multiline comment support in json-pure.
  • Fix JSON.parse to no longer mutate the argument encoding when passed an ASCII-8BIT string.
  • Fix String#to_json to raise on invalid encoding in json-pure.
  • Delete code that was based on CVTUTF.
  • Use the pure-Ruby generator on TruffleRuby.
  • Fix strict mode in json-pure to not break on Integer.

JSON.dump Performance

JSON.dump is now much faster, and on par or faster than alternative implementations:

== Encoding citm_catalog.json (500298 bytes)
ruby 3.4.0preview2 (2024-10-07 master 32c733f57b) +YJIT +PRISM [arm64-darwin23]
Warming up --------------------------------------
        json (2.7.3)   123.000 i/100ms
                  oj   124.000 i/100ms
Calculating -------------------------------------
        json (2.7.3)      1.312k (± 1.8%) i/s  (761.91 μs/i) -      6.642k in   5.062192s
                  oj      1.278k (± 2.0%) i/s  (782.35 μs/i) -      6.448k in   5.046587s

Comparison:
json (2.7.2): 884.0 i/s
json (2.7.3): 1312.5 i/s - 1.48x faster
oj: 1278.2 i/s - 1.45x faster

== Encoding twitter.json (466906 bytes)
ruby 3.4.0preview2 (2024-10-07 master 32c733f57b) +YJIT +PRISM [arm64-darwin23]
Warming up --------------------------------------
        json (2.7.3)   213.000 i/100ms
                  oj   222.000 i/100ms
Calculating -------------------------------------
        json (2.7.3)      2.140k (± 2.8%) i/s  (467.19 μs/i) -     10.863k in   5.079099s
                  oj      2.303k (± 3.2%) i/s  (434.27 μs/i) -     11.544k in   5.018239s

Comparison:
        json (2.7.2):     1250.5 i/s
                  oj:     2302.7 i/s - 1.84x  faster
        json (2.7.3):     2140.5 i/s - 1.71x  faster

Full Changelog: ruby/json@v2.7.2...v2.7.3

2.7.2

What's Changed

  • Use rb_sym2str instead of SYM2ID by @jhawthorn in #561
  • Fix memory leak when exception is raised during JSON generation by @peterzhu2118 in #574
  • Remove references to "19" methods in JRuby by @headius in #576
  • Make OpenStruct support as optional by @hsbt in #565
  • Autoload JSON::GenericObject to avoid require ostruct warning in Ruby 3.4 by @tompng in #577
  • Warn to install ostruct if json couldn't load it by @hsbt in #578

New Contributors

Full Changelog: v2.7.1...v2.7.2

2.7.1

What's Changed

Improved

Fixed

Misc

New Contributors

Full Changelog: v2.7.0...v2.7.1

2.7.0

What's Changed

Improved

  • Perf. improvements to Hash#to_json in pure implementation generator. by @vipulnsward in #203
  • Remove unnecessary initialization of create_id in JSON.parse() by @Watson1978 in #454

Added

Fixed

Compatibility changes

  • JRuby requires a minimum of Java 8 by @headius in #516
  • Rename JSON::ParseError to JSON:ParserError by @dalizard in #530
  • Removed code for Ruby 1.8 by @hsbt in #540
  • alias_method is private on Ruby 2.3 and 2.4 by @hsbt in #541
  • remove_method of Module is private at Ruby 2.3 and 2.4 by @hsbt in #544
  • [jruby] avoid using deprecated BigDecimal.new by @kares in #546
  • Always indent even if empty by @headius in #517

Misc

  • Update CI matrix by @hsbt in #521
  • Add missing changelog entries for 1.8.5 and 1.8.6 by @r7kamura in #520
  • Actions workflow - Add new OS's, Ruby 3.1, Ruby master, Windows by @MSP-Greg in #491
  • Skip unsupported test on JRuby by @nobu in #532
  • Skip BigDecimal tests when it's missing to load by @hsbt in #533
  • Simplify by @nobu in #531
  • Load extension ('json/ext') consistently in test_ext by @aeroastro in #536
  • Use test-unit-ruby-core gem by @hsbt in #539
  • [CI] Add Windows mswin job by @MSP-Greg in #545
  • Exclude truffleruby-head from Actions by @hsbt in #551
  • tests/ractor_test.rb: make assert_separately available by @lucaskanashiro in #506
  • Added changes for 2.7.0 and restore entries to 2.6.3 and 2.6.2 by @hsbt in #552

New Contributors

Full Changelog: v2.6.3...v2.7.0

2.6.3

What's Changed

  • bugfix json/pure mixing escaped with literal unicode raises Encoding::CompatibilityError by @notEthan in #483
  • Stop including the parser source LINE in exceptions by @casperisfine in #470

New Contributors

Full Changelog: v2.6.2...v2.6.3

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ parallel (indirect, 1.22.1 → 1.26.3) · Repo

Commits

See the full diff on Github. The new version differs by 44 commits:

↗️ parser (indirect, 3.1.2.1 → 3.3.5.0) · Repo · Changelog

Release Notes

Too many releases to show here. View the full release notes.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ regexp_parser (indirect, 2.6.0 → 2.9.2) · Repo · Changelog

Release Notes

2.9.2 (from changelog)

Fixed

  • made the MFA requirement for changes to this gem visible on rubygems

2.9.1 (from changelog)

Fixed

  • fixed unnecessary $LOAD_PATH searches at load time

2.9.0 (from changelog)

Added

  • all expressions now respond to #negative? / #negated?
    • previously only sets, props, and posix classes did
  • implemented #negative? / #negated? for more applicable expressions
    • \B, \D, \H, \S, \W, (?!...), (?<!...)

Fixed

  • fixed missing support for grapheme cluster break unicode properties
    • e.g. /\p{Grapheme_Cluster_Break=Extend}/

2.8.3 (from changelog)

Fixed

  • fixed scanner errors for insignificant leading zeros in numerical group refs
    • e.g. (a)\k<01>, (a)\g<-01>, (a)?(?(01)b|c)
    • thanks to Markus Schirp for the report

2.8.2 (from changelog)

Fixed

  • handle a corner case where parsing redundant number escapes raised an error
    • e.g. parse(/\99/), which in Ruby is a valid Regexp that matches 99
    • thanks to Markus Schirp for the report

2.8.1 (from changelog)

Fixed

  • support for extpict unicode property, added in Ruby 2.6
  • support for 10 unicode script/block properties added in Ruby 3.2

2.8.0 (from changelog)

Added

  • Regexp::Expression::Shared#ends_at
    • e.g. parse(/a +/x)[0].ends_at # => 3
    • e.g. parse(/a +/x)[0].ends_at(include_quantifier = false) # => 1
  • Regexp::Expression::Shared#{capturing?,comment?}
    • previously only available on capturing and comment groups
  • Regexp::Expression::Shared#{decorative?}
    • true for decorations: comment groups as well as comments and whitespace in x-mode
  • Regexp::Expression::Shared#parent
  • new format argument :original for Regexp::Expression::Base#to_s
    • includes decorative elements between node and its quantifier
    • e.g. parse(/a (?#comment) +/x)[0].to_s(:original) # => "a (?#comment) +"
    • using it is not needed when calling Root#to_s as Root can't be quantified
  • support calling Subexpression#{each_expression,flat_map} with a one-argument block
    • in this case, only the expressions are passed to the block, no indices
  • support calling test methods at Expression class level
    • capturing?, comment?, decorative?, referential?, terminal?
    • e.g. Regexp::Expression::CharacterSet.terminal? # => false

Fixed

  • Regexp::Expression::Shared#full_length with whitespace before quantifier
    • e.g. parse(/a +/x)[0].full_length used to yield 2, now it yields 3
  • Subexpression#to_s output with children with whitespace before their quantifier
    • e.g. parse(/a + /x).to_s used to yield "a+ ", now it yields "a + "
    • calling #to_s on sub-nodes still omits such decorative interludes by default
      • use new #to_s format :original to include it
      • e.g. parse(/a + /x)[0].to_s(:original) # => "a +"
  • fixed Subexpression#te behaving differently from other expressions
    • only Subexpression#te used to include the quantifier
    • now #te is the end index without quantifier, as for other expressions
  • fixed NoMethodError when calling #starts_at or #ts on empty sequences
    • e.g. Regexp::Parser.parse(/|/)[0].starts_at
    • e.g. Regexp::Parser.parse(/[&&]/)[0][0].starts_at
  • fixed nested comment groups breaking local x-options
    • e.g. in /(?x:(?#hello)) /, the x-option wrongly applied to the whitespace
  • fixed nested comment groups breaking conditionals
    • e.g. in /(a)(?(1)b|c(?#hello)d)e/, the 2nd conditional branch included "e"
  • fixed quantifiers after comment groups being mis-assigned to that group
    • e.g. in /a(?#foo){3}/ (matches 'aaa')
  • fixed Scanner accepting two cases of invalid Regexp syntax
    • unmatched closing parentheses ()) and k-backrefs with number 0 (\k<0>)
    • these are a SyntaxError in Ruby, so could only be passed as a String
    • they now raise a Regexp::Scanner::ScannerError
  • fixed some scanner errors not inheriting from Regexp::Scanner::ScannerError
  • reduced verbosity of inspect / pretty print output

2.7.0 (from changelog)

Added

  • Regexp::Lexer.lex now streams tokens when called with a block
    • it can now take arbitrarily large input, just like Regexp::Scanner
    • this also slightly improves Regexp::Parser.parse performance
    • note: Regexp::Parser.parse still does not and will not support streaming
  • improved performance of Subexpression#each_expression
  • minor improvements to Regexp::Scanner performance
  • overall improvement of parse performance: about 10% for large Regexps

Fixed

  • parsing of octal escape sequences in sets, e.g. [\141]

2.6.2 (from changelog)

Fixed

  • fixed SystemStackError when cloning recursive subexpression calls
    • e.g. Regexp::Parser.parse(/a|b\g<0>/).dup

2.6.1 (from changelog)

Fixed

  • fixed scanning of two negative lookbehind edge cases
    • (?<!x)y> used to raise a ScannerError
    • (?<!x>)y used to be misinterpreted as a named group
    • thanks to Sergio Medina for the report

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ rubocop-ast (indirect, 1.23.0 → 1.32.3) · Repo · Changelog

Release Notes

Too many releases to show here. View the full release notes.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ ruby-progressbar (indirect, 1.11.0 → 1.13.0) · Repo · Changelog

Release Notes

1.13.0 (from changelog)

Add

  • Ability To Allow Different Projectors To Be Used For Time Estimates
  • Concept Of A Projector
  • Ability To Access Progress Bar Instance Using Enumerator Refinement

Remove

  • smoothing Option

Change

  • Issue Caused By Ruby Bug

1.12.0 (from changelog)

Add

  • Ability To Swap Out Running Average Calculators
  • running_average_rate As Configuration Option
  • Wall Clock Time To Completion To The Format Elements

Change

  • Rename Running Average Calculator To Smoothed Average Calculator
  • Rename smoothing To running_average_rate
  • Rename smoothing_factor To rate
  • Allow Timer's Elapsed Seconds To Calculate Even If Not Started

Does any of this look wrong? Please let us know.

↗️ unicode-display_width (indirect, 2.3.0 → 2.6.0) · Repo · Changelog

Release Notes

2.6.0 (from changelog)

  • Unicode 16

2.5.0 (from changelog)

  • Unicode 15.1

2.4.2 (from changelog)

More performance improvements:

  • Optimize lookup of first 4096 codepoints
  • Avoid overwrite lookup if no overwrites are set

2.4.1 (from changelog)

  • Improve general performance!
  • Further improve performance for ASCII strings

You should really upgrade - it's much faster now!

2.4.0 (from changelog)

  • Improve performance for ASCII-only strings, by @fatkodima
  • Require Ruby 2.4

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 32 commits:

🆕 language_server-protocol (added, 3.17.0.3)

🆕 racc (added, 1.8.1)

🗑️ rexml (removed)


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Oct 27, 2024
@depfu depfu bot assigned Narnach Oct 27, 2024
@depfu depfu bot requested a review from Narnach October 27, 2024 09:16
Copy link
Contributor Author

depfu bot commented Dec 13, 2024

Closed in favor of #84.

@depfu depfu bot closed this Dec 13, 2024
@depfu depfu bot deleted the depfu-update-rubocop-rspec-3.2.0 branch December 13, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant