Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish recovered sidecars on gossip #91

Draft
wants to merge 1 commit into
base: das
Choose a base branch
from

Conversation

zilm13
Copy link
Collaborator

@zilm13 zilm13 commented Jul 23, 2024

Addressing ethereum/consensus-specs#3794
There is one issue in it: these sidecars will pass onNewValidatedDataColumnSidecar(DataColumnSidecar dataColumnSidecar) twice but I don't see any fatal consequences from this, though we could try to improve this in the future. Or maybe add comment to not forget.

@Nashatyrev
Copy link
Owner

This PR basically reseeds only the columns which were requested locally, but missed and then recovered.
I believe cross-seeding should be a separate component which tracks gossiped columns, detect missed ones and checks if we locally have > 50% to recover.
It also needs to implement a 'random' cooldown timeout

@zilm13
Copy link
Collaborator Author

zilm13 commented Aug 14, 2024

Also

  • we don't need to cross-seed historical columns
  • we should cross-seed only if we were able to recover 100%
  • we should cross-seed all recovered (missed), not only those we requested

@zilm13 zilm13 marked this pull request as draft August 14, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants