Publish recovered sidecars on gossip #91
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing ethereum/consensus-specs#3794
There is one issue in it: these sidecars will pass
onNewValidatedDataColumnSidecar(DataColumnSidecar dataColumnSidecar)
twice but I don't see any fatal consequences from this, though we could try to improve this in the future. Or maybe add comment to not forget.