Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades Ruff from version 0.8.x to 0.13.3 and addresses linting issues discovered by the newer version. The upgrade ensures consistency between local development and GitHub Actions environments.
- Updated Ruff and ruff-lsp versions in dependency specifications
- Fixed linting violations related to unnecessary string conversions in logging statements
- Added documentation for VSCode Ruff extension configuration
- Implemented Sphinx autodoc configuration to skip Pydantic methods
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Updated Ruff and ruff-lsp version constraints |
| docs/source/dev/README.rst | Added VSCode configuration guidance for Ruff extension |
| docs/source/conf.py | Added Sphinx setup to skip Pydantic model methods from documentation |
| compass/validation/location.py | Removed unnecessary string conversion in logging statement |
| compass/validation/content.py | Removed unnecessary string conversion in logging statement |
| compass/scripts/process.py | Removed unnecessary string conversion in logging statement |
| compass/extraction/wind/ordinance.py | Removed unnecessary string conversions in multiple logging statements |
| compass/extraction/solar/ordinance.py | Removed unnecessary string conversions in multiple logging statements |
| compass/extraction/date.py | Removed unnecessary string conversion in logging statement |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Collaborator
Author
|
@castelao any comments or can I go ahead and merge? |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 8, 2025
* Update Ruff * Add ruff extension instructions for VSCode * Skip pydantic members in docs * Linter fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were several versions behind, which started causing our GHA to find lints that we were not seeing locally.
This PR bumps the Ruff version and fixes outstanding linter issues.