Skip to content

Part 2 of plugin refactor #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ppinchuk wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Part 2 of plugin refactor #377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
9d9af2d
Add debug logging
ppinchuk Feb 6, 2026
80f5d1a
Implement and use `PromptBasedTextExtractor`
ppinchuk Feb 7, 2026
0e06c07
Break uo plugin class into a filtered one and ordinance one
ppinchuk Feb 7, 2026
f187cd1
Add and use `PromptBasedTextCollector`
ppinchuk Feb 7, 2026
5fc4857
Change class name
ppinchuk Feb 7, 2026
fcb00fb
Add validation logic
ppinchuk Feb 7, 2026
bf7f128
Allow plugins to register own districts
ppinchuk Feb 7, 2026
b9e30fc
Add validation logic
ppinchuk Feb 7, 2026
d3abfb6
Allow `JURISDICTION_DATA_FP` property
ppinchuk Feb 7, 2026
df89a77
Add import
ppinchuk Feb 7, 2026
8e3958d
Add MVP of registry
ppinchuk Feb 7, 2026
de3a664
Populate namespace
ppinchuk Feb 7, 2026
e820a99
Plugins now register themselves
ppinchuk Feb 7, 2026
110a4cb
Now run based on plugin registry
ppinchuk Feb 7, 2026
1ae2934
Cleaned file names now specified via a registry
ppinchuk Feb 7, 2026
bee7d23
Import to register plugins
ppinchuk Feb 7, 2026
42980ff
Pass down tech name to cleaned file writing
ppinchuk Feb 7, 2026
e436bd9
Register cleaned file names
ppinchuk Feb 7, 2026
86fc259
Fix tests
ppinchuk Feb 7, 2026
9ae73eb
Rename file
ppinchuk Feb 7, 2026
155b16e
Fix docs
ppinchuk Feb 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions compass/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,13 @@
from ._version import __version__
from .utilities.logs import setup_logging_levels, COMPASS_DEBUG_LEVEL

# Temporarily import to register plugins
# Can drop once plugins register themselves
from .extraction import (
COMPASSWindExtractor,
COMPASSSolarExtractor,
COMPASSSmallWindExtractor,
TexasWaterRightsExtractor,
)
Comment on lines +6 to +13
Copy link

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Importing all extraction plugins in compass.__init__ to force registration adds significant import-time side effects (loads pandas/LLM-related modules, runs register_plugin, mutates registries) for any consumer that imports any compass.* module. Prefer an explicit plugin registration entrypoint (e.g., compass.plugin.discover_plugins() called by the CLI) or lazy registration to keep library imports lightweight and reduce circular-import risk.

Copilot uses AI. Check for mistakes.

setup_logging_levels()
7 changes: 7 additions & 0 deletions compass/extraction/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,10 @@
extract_relevant_text_with_ngram_validation,
extract_ordinance_values,
)

# Temporarily import to register plugins
# Can drop once plugins register themselves
from .wind import COMPASSWindExtractor
from .solar import COMPASSSolarExtractor
from .small_wind import COMPASSSmallWindExtractor
from .water import TexasWaterRightsExtractor
747 changes: 262 additions & 485 deletions compass/extraction/small_wind/ordinance.py
View file
Open in desktop

Large diffs are not rendered by default.

7 changes: 5 additions & 2 deletions compass/extraction/small_wind/plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
"""COMPASS wind extraction plugin"""

from compass.plugin.interface import ExtractionPlugin
from compass.plugin import OrdinanceExtractionPlugin, register_plugin
from compass.extraction.small_wind.ordinance import (
SmallWindHeuristic,
SmallWindOrdinanceTextCollector,
Expand Down Expand Up @@ -60,7 +60,7 @@
}


class COMPASSSmallWindExtractor(ExtractionPlugin):
class COMPASSSmallWindExtractor(OrdinanceExtractionPlugin):
"""COMPASS small wind extraction plugin"""

IDENTIFIER = "small wind"
Expand Down Expand Up @@ -96,3 +96,6 @@ class COMPASSSmallWindExtractor(ExtractionPlugin):
StructuredSmallWindPermittedUseDistrictsParser,
]
"""Class for parsing structured ordinance data from text"""


register_plugin(COMPASSSmallWindExtractor)
Loading
Loading