Merged
Conversation
12 tasks
Member
|
@Myoldmopar To Do Fix license in:
|
Member
|
@jasondegraw I fixed the license in the two diagnostic files and the doc tool file. Can you confirm it's all good? I believe it will be ready to go once CI approves and you confirm. |
Member
|
Unknown why the github mac instance failed, but it's nothing to do with this. This looks ready to go in now. Am I missing anything @jasondegraw ? |
Member
Author
|
@Myoldmopar No, I don't think you've missed anything, I think this can go in. I pulled it, ran the script, and everything seemed to be in order. The scripting around updating the license year will need to be brought into line with these changes, but that can wait until my annual foray into mass editing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
The current license checker doesn't check Python files, this addresses that shortcoming and expands the coverage of C/C++ a little (a newer subdirectory wasn't getting hit). These files are spread out a bit so the search is a little more broad. This should be merged after #8445.
The script is changed so that it can handle the Python version of the license and all of the Python code that I could find should now have (or will have soon) the correct license.
Fixes #8446
Pull Request Author
Add to this list or remove from it as applicable. This is a simple templated set of guidelines.
Reviewer
This will not be exhaustively relevant to every PR.