Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
119 commits
Select commit Hold shift + click to select a range
95503ff
Merge branch 'develop' into Separate-Design-and-Control-Variables
jmythms Nov 30, 2020
bf828f4
Changes to IDD
jmythms Nov 30, 2020
2a7f89c
Missed the design keywords.
jmythms Dec 8, 2020
ec2081e
Removed proposed
jmythms Dec 8, 2020
7eb4896
Updated changes to IDD file
jmythms Dec 10, 2020
b2ac926
move everything to a directory
jmythms Dec 13, 2020
2e686df
Merge branch 'Separate-Design-and-Control-Variables' of https://githu…
jmythms Dec 13, 2020
9be318f
deletions
jmythms Dec 13, 2020
5c110b1
Fix image
jmythms Dec 13, 2020
97857cc
Updated conversations
jmythms Dec 13, 2020
8735e17
updated figure 1)
jmythms Dec 13, 2020
124b610
Merge branch 'Separate-Design-and-Control-Variables' of https://githu…
jmythms Dec 13, 2020
2dcfa6f
updated breakdown images
jmythms Dec 13, 2020
b04f7c0
Updated images.
jmythms Dec 14, 2020
6d3efcd
Updated IOREF - LTRad
jmythms Dec 14, 2020
ba8a620
Updated IOREF - LTRadConvFlow
jmythms Dec 14, 2020
8b35e78
Update IOREF - LTRadConvFlow fields
jmythms Dec 14, 2020
9ea3d90
Update IOREF - LTBaseboardWater
jmythms Dec 14, 2020
07d2dd1
Updated IOREF - LTBaseboardSteam
jmythms Dec 14, 2020
dfc588c
Updated next steps
jmythms Dec 14, 2020
c035886
Update changes to IDD files
jmythms Dec 14, 2020
a6c9a32
Removed approach
jmythms Dec 14, 2020
91cdb04
Final polishing
jmythms Dec 15, 2020
646b86b
Cleanup
jmythms Dec 15, 2020
19deb29
reordered idd
jmythms Dec 15, 2020
5f56b62
Left the date open.
jmythms Dec 15, 2020
e6de91f
Marker: Suggestions from Matt
jmythms Dec 29, 2020
42d1413
first commit, dunno how FindItemInList works
jmythms Jan 5, 2021
74a018b
Merge branch 'Separate-Design-and-Control-Variables' of https://githu…
jmythms Jan 5, 2021
442dd13
Add test IDF
jmythms Jan 5, 2021
306f53a
working hot throttl
jmythms Jan 6, 2021
0430b87
Merge remote-tracking branch 'origin/develop' into Separate-Design-an…
jmythms Jan 6, 2021
72e0ffb
Merge remote-tracking branch 'origin/develop' into Separate-Design-an…
jmythms Jan 6, 2021
89a801d
Condensation Control Dewpoint Offset
jmythms Jan 7, 2021
db0d94b
CondDewPtDeltaT
jmythms Jan 8, 2021
badd34d
Working regression tool
jmythms Jan 10, 2021
2e295e2
Cooling Control Throttling Range
jmythms Jan 11, 2021
2ddcc8a
CoolingCapMethod, ScaledCoolingCapacity. FractionOfAutosizedCoolingCa…
jmythms Jan 14, 2021
91dad04
Cooling Control Temperature Schedule Name
jmythms Jan 15, 2021
3654e21
Heating Control Temperature Schedule Name
jmythms Jan 15, 2021
67ecfa4
Heating Design Capacity Method+Heating Design Capacity+Heating Design…
jmythms Jan 15, 2021
23c7cfe
Conductivity+VarFlowTubeConductivity+VarFlowControlType lots to fix
jmythms Jan 18, 2021
5cad020
FluidToSlabHeatTransfer+TubeDiameterOuter+TubeDiameterInner
jmythms Jan 19, 2021
f07b975
ConstFlow done with errors in VarFlow
jmythms Jan 21, 2021
3381d58
Fixed for var flow
jmythms Jan 22, 2021
b6c8adf
both varflow and const flow working, need to check electric
jmythms Jan 22, 2021
b29ba9f
Regression fixed
jmythms Jan 25, 2021
578f0e1
fixed regression by changing Cflow IDF
jmythms Jan 26, 2021
035781d
working BaseBoard:Water + Broken regressions for it'
jmythms Jan 29, 2021
dc60920
Revert "working BaseBoard:Water + Broken regressions for it'"
jmythms Jan 30, 2021
27391b1
just one variable
jmythms Jan 31, 2021
06a4757
fracrad + fracradppl
jmythms Jan 31, 2021
3551ac7
Fixed regressions for HWBaseboard
jmythms Jan 31, 2021
97147b1
forgot to commit, before HeatCapacity?
jmythms Feb 2, 2021
abcfc2d
Steam: Regressions failing Build working
jmythms Feb 2, 2021
4ea7807
Steam no diffs need to add Heat Cap
jmythms Feb 2, 2021
45f8615
Fixed regression steam
jmythms Feb 2, 2021
2e2b8e2
VarFlow: moved design obj to second
jmythms Feb 2, 2021
064722f
Changeover Delay Time Period Schedule-dunno
jmythms Feb 3, 2021
8e9d4ef
Reordered Varflow Design Obj
jmythms Feb 3, 2021
ec00f77
Regression test start: Add transitioned files + fix calculateUFromISO…
jmythms Feb 6, 2021
6c4f77e
fixed all regression errors
jmythms Feb 7, 2021
f5f7511
fixed calculateLowTemperatureRadiantSystem
jmythms Feb 7, 2021
17d3ef3
fixed ChangeoverDelay IDF
jmythms Feb 7, 2021
384e2a7
Fixed unit tests
jmythms Feb 8, 2021
45d5483
Conflict resolution: SteamBaseboard.cc
jmythms Feb 9, 2021
1b181cc
CI run intiate
jmythms Feb 9, 2021
72e042f
renamed yaml files
jmythms Feb 9, 2021
df4d1d6
Merge branch 'develop' into Separate-Design-and-Control-Variables
jmythms Feb 12, 2021
9ad89d7
Deleted unnecessary testfiles
jmythms Feb 12, 2021
bfb2a37
fix EIO: changed Cooling Cap Method assignment
jmythms Feb 12, 2021
488e9af
Fixed IDFs: Fix regression tests?
jmythms Feb 12, 2021
a4c2219
fix regressions: re-added Cooling Cap assignment
jmythms Feb 12, 2021
75d9a91
Fix HWBaseboard Sched assignment
jmythms Feb 12, 2021
11bab5b
fix regressions:Cooling Cap method
jmythms Feb 12, 2021
15e0ab0
deleted unnecessary files
jmythms Feb 12, 2021
1033358
Fix field names -HW Baseboard
jmythms Feb 12, 2021
d87016b
Removed HeatingCapFlag -HW Baseboard
jmythms Feb 12, 2021
a2beef5
reordred convergence tolerance - HW Baseboard
jmythms Feb 12, 2021
df17a43
fix formatting
jmythms Feb 12, 2021
4e8d7c0
InputRules
jmythms Feb 14, 2021
62ac932
Doc v1
jmythms Feb 15, 2021
d19af24
Deleted yaml files
jmythms Feb 15, 2021
2c40b6c
Fixed CFlow reorder: 2
jmythms Feb 15, 2021
6b6ab61
Fixed Expand Objects Transition
jmythms Feb 15, 2021
ae5c15f
Develop merged
jmythms Feb 15, 2021
1d53a55
changes to Doc: Doc V2
jmythms Feb 15, 2021
51050c1
Added Cond Control Dewpoint Offset to Docs
jmythms Feb 16, 2021
7c13142
InputRules-Typo
jmythms Feb 16, 2021
e8f8ad3
IDFs converted group 1
jmythms Feb 16, 2021
4c74c97
IDFs converted group 2
jmythms Feb 16, 2021
e82de30
IDFs converted group 3
jmythms Feb 16, 2021
ae16d49
IDFs converted group 4
jmythms Feb 16, 2021
338038c
IDFs converted group 5
jmythms Feb 16, 2021
8c6cd3c
Transition and fix unit test
jmythms Feb 16, 2021
3176ff4
fix doc labels
jmythms Feb 16, 2021
de75cf9
IDD: min fields
jmythms Feb 16, 2021
2b4aef4
IDD: memos
jmythms Feb 16, 2021
fdf0cd2
fixed variableFlowDesignDataObject.HotSetptSchedPtr == 0
jmythms Feb 16, 2021
f2271f8
fixed variableFlowDesignDataObject.HotSetptSchedPtr == 0 2
jmythms Feb 16, 2021
8af7434
fixed Heating, Cooling Design Method messages
jmythms Feb 16, 2021
1772d28
Fixes+TODOs : Messages
jmythms Feb 16, 2021
4edde20
Documentation fix + removed TODO
jmythms Feb 16, 2021
dff2cc0
Remove redundant design obj in IDFs
jmythms Feb 16, 2021
6dce325
Remove redundant design obj in IDFs 2
jmythms Feb 16, 2021
e295c14
Remove redundant design obj in IDFs 3 + changed documentation label t…
jmythms Feb 16, 2021
15a1134
Transition CONSTFLOW
jmythms Feb 17, 2021
bf30fb6
Transition VFLOW
jmythms Feb 17, 2021
364dc33
Transition HWBB + VFLOW fix
jmythms Feb 17, 2021
071f3d0
Transition SteamBB
jmythms Feb 17, 2021
4ee3041
InputRules Fix
jmythms Feb 17, 2021
625bce2
DesignDoc fix
jmythms Feb 17, 2021
7123623
Fix last line for Cflo + VarFlow
jmythms Feb 17, 2021
80b2a37
Added CurVarIterator to fix last line
jmythms Feb 18, 2021
ff05129
Removed nodiff
jmythms Feb 18, 2021
5eb244f
IDD Note Edit+ Change to PascalCase
jmythms Feb 18, 2021
4a10ee1
markdown lists
jmythms Feb 18, 2021
916049f
Deleted unnecessary makefiles
jmythms Feb 18, 2021
85cdfb6
Fixed double spacing in IDD
jmythms Feb 18, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -0,0 +1,166 @@

Separate Design and Control Variables - Changes to IDD file
================

The metadata to remain same, so it was taken out to improve readability.

## LowTemperatureRadiant:VariableFlow Objects ##


**ZoneHVAC:LowTemperatureRadiant:VariableFlow:Design,**

A1 , \field Name
A2 , \field Fluid to Radiant Surface Heat Transfer Model
N1 , \field Hydronic Tubing Inside Diameter
N2 , \field Hydronic Tubing Outside Diameter
N3 , \field Hydronic Tubing Conductivity
A3 , \field Temperature Control Type
A4 , \field Setpoint Control Type
A5 , \field Heating Design Capacity Method
N4 , \field Heating Design Capacity Per Floor Area
N5 , \field Fraction of Autosized Heating Design Capacity
N6 , \field Heating Control Throttling Range
A6 , \field Heating Control Temperature Schedule Name
A7 , \field Cooling Design Capacity Method
N7 , \field Cooling Design Capacity Per Floor Area
N8 , \field Fraction of Autosized Cooling Design Capacity
N9 , \field Cooling Control Throttling Range
A8 , \field Cooling Control Temperature Schedule Name
A9 , \field Condensation Control Type
N10, \field Condensation Control Dewpoint Offset
A10; \field Changeover Delay Time Period Schedule

**ZoneHVAC:LowTemperatureRadiant:VariableFlow,**

A1 , \field Name
A2 , \field Design Object Name
A3 , \field Availability Schedule Name
A4 , \field Zone Name
A5 , \field Surface Name or Radiant Surface Group Name
N1 , \field Hydronic Tubing Length
N2 , \field Heating Design Capacity
N3 , \field Maximum Hot Water Flow
A6 , \field Heating Water Inlet Node Name
A7 , \field Heating Water Outlet Node Name
N4 , \field Cooling Design Capacity
N5 , \field Maximum Cold Water Flow
A8 , \field Cooling Water Inlet Node Name
A9 , \field Cooling Water Outlet Node Name
A10, \field Number of Circuits
N6 ; \field Circuit Length

## LowTemperatureRadiant:ConstantFlow Objects ####

**ZoneHVAC:LowTemperatureRadiant:ConstantFlow:Design,**

A1 , \field Name
A2 , \field Fluid to Radiant Surface Heat Transfer Model
A3 , \field Temperature Control Type
N1 , \field Running Mean Outdoor Dry-Bulb Temperature Weighting Factor
N2 , \field Hydronic Tubing Inside Diameter
N3 , \field Hydronic Tubing Outside Diameter
N4 , \field Hydronic Tubing Conductivity
N5 , \field Motor Efficiency
N6 , \field Fraction of Motor Inefficiencies to Fluid Stream
A4 , \field Condensation Control Type
N7 , \field Condensation Control Dewpoint Offset
A5 ; \field Changeover Delay Time Period Schedule

**ZoneHVAC:LowTemperatureRadiant:ConstantFlow,**

A1 , \field Name
A2 , \field Design Object Name
A3 , \field Availability Schedule Name
A4 , \field Zone Name
A5 , \field Surface Name or Radiant Surface Group Name
N1 , \field Hydronic Tubing Length
N2 , \field Rated Flow Rate
A6 , \field Pump Flow Rate Schedule Name
N3 , \field Rated Pump Head
N4 , \field Rated Power Consumption
A7 , \field Heating Water Inlet Node Name
A8 , \field Heating Water Outlet Node Name
A9 , \field Heating High Water Temperature Schedule Name
A10, \field Heating Low Water Temperature Schedule Name
A11, \field Heating High Control Temperature Schedule Name
A12, \field Heating Low Control Temperature Schedule Name
A13, \field Cooling Water Inlet Node Name
A14, \field Cooling Water Outlet Node Name
A15, \field Cooling High Water Temperature Schedule Name
A16, \field Cooling Low Water Temperature Schedule Name
A17, \field Cooling High Control Temperature Schedule Name
A18, \field Cooling Low Control Temperature Schedule Name
A19, \field Number of Circuits
N5 ; \field Circuit Length


## Baseboard:RadiantConvective:Water Objects ####

**ZoneHVAC:Baseboard:RadiantConvective:Water,**

\memo Design parameters for ZoneHVAC:Baseboard:RadiantConvective objects
A1 , \field Name
A2 , \field Heating Design Capacity Method
N1 , \field Heating Design Capacity Per Floor Area
N2 , \field Fraction of Autosized Heating Design Capacity
N3 , \field Convergence Tolerance
N4 , \field Fraction Radiant
N5 ; \field Fraction of Radiant Energy Incident on People

**ZoneHVAC:Baseboard:RadiantConvective:Water,**

\min-fields 8
A1, \field Name
A2, \field Availability Schedule Name
A3, \field Inlet Node Name
A4, \field Outlet Node Name
N1, \field Rated Average Water Temperature
N2, \field Rated Water Mass Flow Rate
N3, \field Heating Design Capacity
N4, \field Maximum Water Flow Rate
A5, \field Design Object Name
A6, \field Surface 1 Name
N5, \field Fraction of Radiant Energy to Surface 1
A7, \field Surface 2 Name
N6, \field Fraction of Radiant Energy to Surface 2
.
.
.
A105, \field Surface 100 Name
N104; \field Fraction of Radiant Energy to Surface 100

## Baseboard:RadiantConvective:Steam Objects ####

### Proposed

**ZoneHVAC:Baseboard:RadiantConvective:Steam,**

\memo Design parameters for ZoneHVAC:Baseboard:RadiantConvective objects
A1 , \field Name
A2 , \field Heating Design Capacity Method
N1 , \field Heating Design Capacity Per Floor Area
N2 , \field Fraction of Autosized Heating Design Capacity
N3 , \field Convergence Tolerance
N4 , \field Fraction Radiant
N5 ; \field Fraction of Radiant Energy Incident on People

**ZoneHVAC:Baseboard:RadiantConvective:Steam,**

\min-fields 7
A1, \field Name
A2, \field Availability Schedule Name
A3, \field Inlet Node Name
A4, \field Outlet Node Name
N1, \field Heating Design Capacity
N2, \field Degree of SubCooling
N3, \field Maximum Steam Flow Rate
A5, \field Design Object Name
A6, \field Surface 1 Name
N4, \field Fraction of Radiant Energy to Surface 1
A7, \field Surface 2 Name
N5, \field Fraction of Radiant Energy to Surface 2
.
.
.
A105, \field Surface 100 Name
N103; \field Fraction of Radiant Energy to Surface 100
Loading