Enhancement: Add flexibility to the Monte Carlo analysis PlantData initialization#307
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #307 +/- ##
===========================================
- Coverage 72.49% 69.92% -2.58%
===========================================
Files 29 29
Lines 3690 3840 +150
Branches 796 573 -223
===========================================
+ Hits 2675 2685 +10
- Misses 826 967 +141
+ Partials 189 188 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ejsimley
left a comment
There was a problem hiding this comment.
Thanks for submitting these fixes and improvements based on the HVS2 work! I appreciate the "apply_iav" option, which makes the code a lot more flexible and the new compute_wind_speed function.
I just have some minor comments to consider.
ejsimley
left a comment
There was a problem hiding this comment.
Thanks for making these changes @RHammond2! I just added a little more to a couple docstrings (feel free to revise).
|
Thanks, @ejsimley, I think it's better with your addition, and will merge this in once the checks pass. |
This PR addresses a series of small features and fixes from the HVS2 work as outlined below.
MonteCarloAEPn_jobsto enable parallelization of each iteration's modelapply_iavto toggle the addition of the interannual variability at the end of the analysis.run::progress_barto toggle the use of a progress bar during the analysis. When running many models, turning off the progress bar for each iteration of a parameter sweep greatly reduces the amount of outputs to scroll through.PlantData'sasset_distance_matrixandasset_direction_matrixvalues. Without the defaults, plants not utilizing location data end up failing at analysis time since no data is able to be passed.