Conversation
jmarrec
added a commit
to NatLabRockies/OpenStudio
that referenced
this pull request
Sep 1, 2022
jmarrec
added a commit
to NatLabRockies/OpenStudio
that referenced
this pull request
Sep 1, 2022
…on c9c2245c0a) [x86_64-linux], Rubocop 0.81.0)
…on c9c2245c0a) [x86_64-linux], Rubocop 0.81.0)
…ariables for two TableLookup
…on c9c2245c0a) [x86_64-linux], Rubocop 0.81.0)
Contributor
joseph-robertson
left a comment
There was a problem hiding this comment.
Have we verified equivalent results across the Gem::Version.new('3.4.0') switch?
17 tasks
jmarrec
added a commit
that referenced
this pull request
Jan 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
Adjust tests to use the TableLookup or TableMultivariableLookup, conditionally based on the version of the SDK
Link to relevant GitHub Issue(s) if appropriate: NatLabRockies/OpenStudio#4652
Link to the Linux.deb installer to use for CI Testing. If not set, it will default to latest official release.
[OpenStudio Installer]: http://openstudio-ci-builds.s3-website-us-west-2.amazonaws.com/PR-4652/OpenStudio-3.4.1-alpha%2B45452eabd2-Ubuntu-18.04.deb
This Pull Request is concerning:
NewTest: a new test for a new model API class,TestFix: a fix for an existing test. The GitHub issue should be referenced in the PR descriptionNewTestForExisting: a new test for an already-existing model API classOther: Something else, like maintenance of the repo, or just committing test results with a new OpenStudio version.Case 2: Fix for an existing test
Please include a link to the specific test you are modifying, and a description of the changes you have made and why they are required.
Work Checklist
The change:
If it affects total site kBTU:
out.oswhave been committed for official OpenStudio versions onlyEither way:
Ruby test is still stable: when run multiple times on the same machine, it produces the same total site kBTU.
model.getThermalZones.sort_by{|z| z.name.to_s}.each do ...so I am sure I put the same ZoneHVAC systems to the same zones regardless of their order)process_results.py(seepython process_results.py --helpfor usage).Please paste the text output or heatmap png generated after running the following commands:
If relevant, new fields that can be autosized have been added to
autosize_hvac.rbto ensure the autosizedXXX values methods do workReview Checklist
# TODOadded tomodel_tests.rbout.oswhave been committedautosize_hvacas appropriateNewTest,TestFix,NewTestForExisting,OtherNewTest: addPendingOSMorAddedOSM