'UseWeatherFile' is not yet a supported option for YearDescription (Bugzilla #979)

[axelstudios]

On 2012-11-01 17:07:02, @macumber wrote:

openstudio::Date YearDescription_Impl::makeDate

See if we can remove this error when a weather file is set

[DavidGoldwasser]

@asparke2 and @mdahlhausen have you noticed this a lot on create typical. This used to just be in console out but now that is written into the out.osw. I'm getting it 5500 times in create_typical measure log vs. only twice in ChangeBuildingLocation.

@tijcolem despite could be good to have someone look at this. Maybe there is change we can make to ruby code and not OpenStudio. I thought we cleaned up some bugs related to logging but not this one.

The full messsage is [openstudio.model.YearDescription] <1> 'UseWeatherFile' is not yet a supported option for YearDescription

[asparke2]

@DavidGoldwasser Yeah it's gotten out of hand, but haven't looked into where it's coming from yet. Getting rid of this would be excellent!

[DavidGoldwasser]

Sorry @kbenne just adding you for a few that were still assigned to Dan. We can change to someone else I just didn't want it un-assigned.

[eringold]

@DavidGoldwasser
I think it's occurring when the standards gem makes schedules, like: here or here

My workaround (for TMY runs) is just to add this right after creating a new model:
model.getYearDescription.setDayofWeekforStartDay("Sunday")

[asparke2]

Here's my analysis of why this is happening:

1. You have a model where "YearDescription -> Day of Week for Start Day" is blank. The OS Application sets this field when you assign a .epw file, but when you programmatically build a model you have to do this yourself.

2. You call YearDescription::makeDate(some_integer), which generates the message 'UseWeatherFile' is not yet a supported option for YearDescription

openstudio-standards calls makeDate() a lot here when used to programatically generate operation schedules for HVAC systems

I think the solution could be to use the cached version of Model::assumedYear() inside YearDescription::makeDate(). The message should also be changed to something meaningful like "YearDescription has not been assigned a specific starting day of the week, making dates assuming calendar year 2009" (or whatever the default year is).

[DavidGoldwasser]

Thanks @eringold and @asparke2. Quick fix for my usecase is to use the set_year argument in change building location, which I have been leaving at 0 which doesn't alter it. Changing that argument to 2019 got rid of the message :) I still agree there is a bug to fix in API, but nice to know how to get around it.
https://github.com/NREL/openstudio-common-measures-gem/blob/develop/lib/measures/ChangeBuildingLocation/measure.rb#L75-L79

[joseph-robertson]

What is the proposed bugfix in the API?