E+ 22.2: ZoneHVAC:PackagedTerminal AirConditionner/HeatPump requires a supply air fan operating mode schedule

[jmarrec]

Issue overview

In 22.2.0, there’s a new error in ZoneHVAC:PackagedTerminal:AC/HP if you don’t supply a Supply Air Fan Operating Mode Schedule when you have a Fan:ConstantVolume

   ** Severe  ** ZoneHVAC:PackagedTerminalAirConditioner = ZONE HVAC PACKAGED TERMINAL AIR CONDITIONER 4
   **   ~~~   ** Fan type must be Fan:OnOff or Fan:SystemModel when Supply Air Fan Operating Mode Schedule Name is blank

Except:

• if I pass a Always 0 schedule, there’s another error saying value must be > 0 for Fan:CV.
• If I pass Always 1 schedule, my EUI changes quite dramatically.
• If I use a Fan:OnOff with always 0, my EUI is closer but still different.

We need a way to handle this so we don't end up with too broken models (lots are failing on OS-resources right now) and ideally without changing EUI too drastically.

cf 9abf9e4#diff-6792272e2d22af45d561660c93bc735d74a30b2a15218ed60d1b05a91eeca176R310

Current Behavior

Expected Behavior

Steps to Reproduce

Possible Solution

Details

Environment

Some additional details about your environment for this issue (if relevant):

• Platform (Operating system, version):
• Version of OpenStudio (if using an intermediate build, include SHA):

Context

[jmarrec]

The change is due to NatLabRockies/EnergyPlus#9273

I took resources/EnergyPlus/Office_HVAC_With_Many_Types.idf and ran some combinations on both 22.1.0 and 22.2.0

I also discussed it with some members of E+ dev team. Seems like a good idea would be to do

If a PTAC had a FanConstantVolume and the op schedule is blank:
    Replace PTAC Fan with FanSystemModel Discrete (=Model a Fan:OnOff) copying inputs where they map
    Set PTAC fan Op schedule to alwaysOff

[jmarrec]

Reg tests right now:

Success    250
Fail        67
Name: (22.2.0, 3.5.0-alpha, 515b977a2c), dtype: int64