Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
bf128b4
Start updating openstudio idd.
joseph-robertson Jan 22, 2020
af63bb3
Merge branch 'develop' into issue-3728
joseph-robertson Nov 9, 2020
614d300
Update idd.
joseph-robertson Nov 10, 2020
be3762f
Stub source files.
joseph-robertson Nov 10, 2020
e7b14bc
Update cmakelists, concretemodelobjects, modelhvac, etc.
joseph-robertson Nov 10, 2020
803daec
Update idd, cmakelists, and schedule type registry.
joseph-robertson Nov 10, 2020
74a4f85
Update source files.
joseph-robertson Nov 10, 2020
2b19e33
Add model tests.
joseph-robertson Nov 10, 2020
22af925
Get optional doas from oas.
joseph-robertson Nov 10, 2020
d77c428
Stub ft and rt and ft tests.
joseph-robertson Nov 10, 2020
b305f68
Remove number of airloops from idd.
joseph-robertson Nov 11, 2020
48e325c
Fix getting doas from oas.
joseph-robertson Nov 11, 2020
7ebb345
Update ft and rt and tests.
joseph-robertson Nov 11, 2020
f244da5
Update ft and test for doas.
joseph-robertson Nov 11, 2020
972212e
Update doas ft and test.
joseph-robertson Nov 11, 2020
482793e
Merge branch 'develop' into issue-3728
joseph-robertson Nov 23, 2020
03df2bf
Apply clang-format to files.
joseph-robertson Nov 23, 2020
13ac20e
Merge branch 'develop' into issue-3728
joseph-robertson Dec 11, 2020
c30d9a7
Merge branch 'develop' into issue-3728
joseph-robertson Dec 16, 2020
a31b8ba
Merge branch 'develop' into issue-3728
joseph-robertson Jan 13, 2021
44292f1
Merge branch 'develop' into issue-3728
joseph-robertson Feb 26, 2021
949c2b2
Clean up model and test files.
joseph-robertson Feb 26, 2021
ef0e333
Ft from outdoor air system and clean up ft tests.
joseph-robertson Feb 26, 2021
4d0bc8b
Switch to model object and fix some headers.
joseph-robertson Mar 1, 2021
88e3f6b
Make AirLoopHVACOutdoorAirSystem more friendly
jmarrec Mar 1, 2021
524f3d3
Ft outdoor air system not on airloop node from doas.
joseph-robertson Mar 1, 2021
d2395ef
Get things really close to working.
joseph-robertson Mar 2, 2021
ff2291c
Merge branch 'develop' into issue-3728
joseph-robertson Mar 2, 2021
78bdd80
Clang format.
joseph-robertson Mar 2, 2021
2e5355c
Add some reference and object-list.
joseph-robertson Mar 2, 2021
0bb8d3a
Get correct splitter inlet node.
joseph-robertson Mar 3, 2021
f883a4a
Update ft test for splitter inlet node.
joseph-robertson Mar 3, 2021
3540eb7
Make availability schedule required.
joseph-robertson Mar 4, 2021
317fa63
Merge branch 'develop' into issue-3728
joseph-robertson Mar 4, 2021
6959bd9
Fix issues when building back and forth between E+ versions
jmarrec Mar 5, 2021
0be7e99
Fix unrelated test due to #4211
jmarrec Mar 2, 2021
31b7ebc
Make the setString test clearer about what happens
jmarrec Mar 5, 2021
d2c94f7
Fix epJSON tests and make ruby not rely on IDF
jmarrec Mar 5, 2021
4c6d179
Use V9.5.0-IOFreeze transition utility to bump all IDF files
jmarrec Mar 5, 2021
7816801
Add the v9.5.0-IOFreeze SQL file for 1ZoneEvapCool: **will have to re…
jmarrec Mar 5, 2021
87d43fc
Fix new cppcheck functionStatic warning due to deprecated method
jmarrec Mar 5, 2021
049844b
Merge branch 'cmake_ep_versions' into issue-3728
jmarrec Mar 5, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 18 additions & 13 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -560,11 +560,6 @@ endif()

# EnergyPlus

if((DEFINED ENERGYPLUS_EXE) AND NOT (ENERGYPLUS_EXE STREQUAL ""))
get_filename_component(OLD_ENERGYPLUS_EXTRACTED_DIR "${ENERGYPLUS_EXE}" DIRECTORY)
message("OLD_ENERGYPLUS_EXTRACTED_DIR=${OLD_ENERGYPLUS_EXTRACTED_DIR}")
endif()

if(UNIX)
if(APPLE)
set(ENERGYPLUS_EXPECTED_HASH 0bf64f4b153a87c3a4822321bc5878e1)
Expand Down Expand Up @@ -601,10 +596,6 @@ if(UNIX)
EXPECTED_MD5 ${ENERGYPLUS_EXPECTED_HASH})
endif()

# Remove the old extracted dir if exists
if(DEFINED OLD_ENERGYPLUS_EXTRACTED_DIR)
execute_process(COMMAND ${CMAKE_COMMAND} -E remove_directory "${OLD_ENERGYPLUS_EXTRACTED_DIR}")
endif()
execute_process(COMMAND ${CMAKE_COMMAND} -E remove_directory "${PROJECT_BINARY_DIR}/${ENERGYPLUS_PATH}")

endif()
Expand All @@ -630,16 +621,30 @@ elseif(WIN32)
SHOW_PROGRESS
EXPECTED_MD5 ${ENERGYPLUS_EXPECTED_HASH})

# Remove the old extracted dir if exists
if(DEFINED OLD_ENERGYPLUS_EXTRACTED_DIR)
execute_process(COMMAND ${CMAKE_COMMAND} -E remove_directory "${OLD_ENERGYPLUS_EXTRACTED_DIR}")
endif()
execute_process(COMMAND ${CMAKE_COMMAND} -E remove_directory "${PROJECT_BINARY_DIR}/${ENERGYPLUS_PATH}")

endif()

endif()

if((DEFINED ENERGYPLUS_EXE) AND NOT (ENERGYPLUS_EXE STREQUAL ""))
get_filename_component(OLD_ENERGYPLUS_EXTRACTED_DIR "${ENERGYPLUS_EXE}" DIRECTORY)
if(NOT "${OLD_ENERGYPLUS_EXTRACTED_DIR}" MATCHES ".*${ENERGYPLUS_PATH}.*")

message(STATUS "Removing old extracted dir = ${OLD_ENERGYPLUS_EXTRACTED_DIR}")
# Remove the old extracted dir
execute_process(COMMAND ${CMAKE_COMMAND} -E remove_directory "${OLD_ENERGYPLUS_EXTRACTED_DIR}")

# Unset variables so that FindEnergyPlus is called again
unset(ENERGYPLUS_FOUND CACHE)
unset(ENERGYPLUS_EXE CACHE)
unset(ENERGYPLUS_IDD CACHE)
unset(ENERGYPLUS_WEATHER_DIR CACHE)

endif()
endif()


# Allows placing the archive manually in the build dir too
if (NOT EXISTS "${ENERGYPLUS_PATH}")
unset(ENERGYPLUS_FOUND CACHE)
Expand Down
1 change: 1 addition & 0 deletions resources/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ set(utilities_resources_src
utilities/SqlFile/1ZoneEvapCooler-V9-2-0.sql
utilities/SqlFile/1ZoneEvapCooler-V9-3-0.sql
utilities/SqlFile/1ZoneEvapCooler-V9-4-0.sql
utilities/SqlFile/1ZoneEvapCooler-V9-5-0.sql
utilities/Zip/test1.zip
)

Expand Down
2 changes: 1 addition & 1 deletion resources/energyplus/5ZoneAirCooled/in.idf
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@
! Environmental Emissions: None
! Utility Tariffs: None

Version,9.4;
Version,9.5;

Building,
Building, !- Name
Expand Down
2 changes: 1 addition & 1 deletion resources/energyplus/BestestEx/in.idf
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
!BESTEST-EX Case L200EX-PH BASE-CASE, developed by NREL
!Use EnergyPlus IDFEditor to view inputs in IP units

Version,9.4;
Version,9.5;

SimulationControl,
No, !- Do Zone Sizing Calculation
Expand Down
2 changes: 1 addition & 1 deletion resources/energyplus/Daylighting_Office/in.idf
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@
! schedule types, always on schedule, misc
! ***GENERAL SIMULATION PARAMETERS***

Version,9.4;
Version,9.5;

SimulationControl,
YES, !- Do Zone Sizing Calculation
Expand Down
2 changes: 1 addition & 1 deletion resources/energyplus/Daylighting_School/in.idf
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
! WeatherFileName=USA_CO_Boulder_TMY2.epw
! End SimMetaData

Version,9.4;
Version,9.5;

Timestep,6;

Expand Down
2 changes: 1 addition & 1 deletion resources/energyplus/HospitalBaseline/in.idf
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@
! End SimMetaData
! Number of Zones: 130

Version,9.4;
Version,9.5;

Timestep,6;

Expand Down
2 changes: 1 addition & 1 deletion resources/energyplus/NewFileTemplate.idf
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
!- =========== ALL OBJECTS IN CLASS: VERSION ===========

Version,9.4;
Version,9.5;

!- =========== ALL OBJECTS IN CLASS: BUILDING ===========

Expand Down
2 changes: 1 addition & 1 deletion resources/energyplus/Office_With_Many_HVAC_Types/in.idf
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Version,9.4;
Version,9.5;

Building,
Building 1, !- Name
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
! ***GENERAL SIMULATION PARAMETERS***
! Number of Zones: 19

Version,9.4;
Version,9.5;

SimulationControl,
YES, !- Do Zone Sizing Calculation
Expand Down
2 changes: 1 addition & 1 deletion resources/energyplus/ScheduleFile/in.idf
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Version,9.4;
Version,9.5;

Timestep,4;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
! Environmental Emissions: None
! Utility Tariffs: None

Version,9.4;
Version,9.5;

Timestep,4;

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
! Basecase reference for SimpleSurfaces_Test
!- =========== ALL OBJECTS IN CLASS: VERSION ===========

Version,9.4;
Version,9.5;

!- =========== ALL OBJECTS IN CLASS: BUILDING ===========

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
! File to test the import of simple surfaces
!- =========== ALL OBJECTS IN CLASS: VERSION ===========

Version,9.4;
Version,9.5;

!- =========== ALL OBJECTS IN CLASS: BUILDING ===========

Expand Down
4 changes: 2 additions & 2 deletions resources/energyplus/SmallOffice/SmallOffice.idf
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
! ExtWallConstruction=Mass
! End SimMetaData

Version,9.4;
Version,9.5;

Timestep,6;

Expand Down Expand Up @@ -5814,7 +5814,7 @@

UtilityCost:Tariff,
IN_EIAMonthlyRateGas, !- Name
NaturalGas:Facility, !- Output Meter Name
NaturalGas:Facility, !- Output Meter Name
MCF, !- Conversion Factor Choice
, !- Energy Conversion Factor
, !- Demand Conversion Factor
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
!- =========== ALL OBJECTS IN CLASS: VERSION ===========

Version,9.4;
Version,9.5;

!- =========== ALL OBJECTS IN CLASS: BUILDING ===========

Expand Down
49 changes: 49 additions & 0 deletions resources/model/OpenStudio.idd
Original file line number Diff line number Diff line change
Expand Up @@ -10198,6 +10198,7 @@ OS:AirLoopHVAC:OutdoorAirSystem,
A2, \field Name
\type alpha
\required-field
\reference AirLoopHVACOASysNames
\reference ConnectionObject
A3, \field Controller Name
\type object-list
Expand Down Expand Up @@ -10229,6 +10230,54 @@ OS:AirLoopHVAC:OutdoorAirSystem,
\required-field
\object-list ConnectionNames

OS:AirLoopHVAC:DedicatedOutdoorAirSystem,
\extensible:1 Just duplicate last field and comments (changing numbering, please)
\min-fields 9
\memo Defines a central forced air system to provide dedicated outdoor air to multiple
\memo AirLoopHVACs.
A1, \field Handle
\type handle
\required-field
A2, \field Name
\required-field
\type alpha
\reference DOASAirLoops
\reference ConnectionObject
A3, \field Outdoor Air System
\note Enter the name of an AirLoopHVAC:OutdoorAirSystem object.
\required-field
\type object-list
\object-list AirLoopHVACOASysNames
\object-list ConnectionObject
A4, \field Availability Schedule
\note Availability schedule name for this system. Schedule value > 0 means the system is available.
\note If this field is blank, the system is always available.
\required-field
\type object-list
\object-list ScheduleNames
N1, \field Preheat Design Temperature
\required-field
\type real
\units C
N2, \field Preheat Design Humidity Ratio
\required-field
\type real
\units kgWater/kgDryAir
N3, \field Precool Design Temperature
\required-field
\type real
\units C
N4, \field Precool Design Humidity Ratio
\required-field
\type real
\units kgWater/kgDryAir
A5; \field Air Loop 1
\note The rest of fields are extensible. It requires AirLoopHVAC names served by
\note an AirLoopHVAC:DedicatedOutdoorAirSystem.
\begin-extensible
\type object-list
\object-list AirPrimaryLoops

OS:AirLoopHVAC:ReturnPlenum,
\extensible:1 Just duplicate last field and comments (changing numbering, please)
\min-fields 1
Expand Down
2 changes: 1 addition & 1 deletion resources/utilities/Idf/CommentTest.idf
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
! Written by Elaine T. Hale, 15 September 2010
! Version object should keep up with EnergyPlus version number.

Version,9.4;
Version,9.5;

! Timestep should be > 1.

Expand Down
2 changes: 1 addition & 1 deletion resources/utilities/Idf/DosLineEndingTest.idf
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
! Written by Elaine T. Hale, 15 September 2010
! Version object should keep up with EnergyPlus version number.

Version,9.4;
Version,9.5;

! Timestep should be > 1.

Expand Down
2 changes: 1 addition & 1 deletion resources/utilities/Idf/FormatPropertyTest_Formatted.idf
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
!- =========== ALL OBJECTS IN CLASS: VERSION ===========
! \format singleLine

Version,9.4;
Version,9.5;

!- =========== ALL OBJECTS IN CLASS: HEATBALANCEALGORITHM ===========
! \format singleLine
Expand Down
2 changes: 1 addition & 1 deletion resources/utilities/Idf/FormatPropertyTest_Unformatted.idf
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
!- =========== ALL OBJECTS IN CLASS: VERSION ===========
! \format singleLine

Version,9.4;
Version,9.5;

!- =========== ALL OBJECTS IN CLASS: HEATBALANCEALGORITHM ===========
! \format singleLine
Expand Down
2 changes: 1 addition & 1 deletion resources/utilities/Idf/MixedLineEndingTest.idf
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
! Written by Elaine T. Hale, 15 September 2010
! Version object should keep up with EnergyPlus version number.

Version,9.4;
Version,9.5;

! Timestep should be > 1.

Expand Down
2 changes: 1 addition & 1 deletion resources/utilities/Idf/UnixLineEndingTest.idf
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
! Written by Elaine T. Hale, 15 September 2010
! Version object should keep up with EnergyPlus version number.

Version,9.4;
Version,9.5;

! Timestep should be > 1.

Expand Down
Loading