Skip to content

Navigation Menu

Appearance settings

View all features
- BY COMPANY SIZE
  Enterprises
  Small and medium teams
  Startups
  Nonprofits
- BY USE CASE
  App Modernization
  DevSecOps
  DevOps
  CI/CD
  View all use cases
- BY INDUSTRY
  Healthcare
  Financial services
  Manufacturing
  Government
  View all industries
View all solutions
- EXPLORE BY TOPIC
  AI
  Software Development
  DevOps
  Security
  View all topics
- EXPLORE BY TYPE
  Customer stories
  Events & webinars
  Ebooks & reports
  Business insights
  GitHub Skills
- SUPPORT & SERVICES
  Documentation
  Customer support
  Community forum
  Trust center
  Partners
- COMMUNITY
  GitHub SponsorsFund open source developers
- PROGRAMS
  Security Lab
  Maintainer Community
  Accelerator
  Archive Program
- REPOSITORIES
  Topics
  Trending
  Collections
- ENTERPRISE SOLUTIONS
  Enterprise platformAI-powered developer platform
- AVAILABLE ADD-ONS
  GitHub Advanced SecurityEnterprise-grade security features
  Copilot for BusinessEnterprise-grade AI features
  Premium SupportEnterprise-grade 24/7 support
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

Appearance settings

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

NatLabRockies / OpenStudio Public

Notifications You must be signed in to change notification settings
Fork 222
Star 582

Code
Issues 233
Pull requests 9
Actions
Projects
Wiki
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Projects
Wiki
Security
Insights

Fix #4205 - WorkspaceObject::setString allows setting invalid names for ModelObjects#4206

Closed

jmarrec wants to merge 4 commits intodevelopNatLabRockies/OpenStudio:developfrom

4205_SetString_WorkspaceObjectNatLabRockies/OpenStudio:4205_SetString_WorkspaceObjectCopy head branch name to clipboard

Conversation Commits4 (4)Checks Files changed

Closed

Fix #4205 - WorkspaceObject::setString allows setting invalid names for ModelObjects#4206
jmarrec wants to merge 4 commits intodevelopfrom
4205_SetString_WorkspaceObject

Commits

Commits on Feb 15, 2021

Add a test for #4205
jmarrec
committed
Fix #4205 - Prevent setString from creating duplicate names
jmarrec
committed
clarify the intent a bit by explicitly calling .get() on optional<unsigned>
jmarrec
committed
Modify test, since the "" (empty) does work...
jmarrec
committed

Comments

Close sidebar

Footer

© 2026 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Community
Docs
Contact

You can’t perform that action at this time.