Merged
Conversation
f97bc28 to
c3425ca
Compare
…re we had made Thermal Conform Model extensible, so now we can't
#4668 - Wrap E+ 22.2 new People fields
jmarrec
reviewed
Sep 2, 2022
| ! V | ||
| ! VA | ||
| ! W/m2 or deg C | ||
| ! W/m2, deg C or cd/m2 |
Collaborator
There was a problem hiding this comment.
This is making IddFactory_Units throw. I'll fix the test
I bumped gfortran from 9 to 11 on E+ GHA runners, it must handle `-static` differently
Found via HPXML testing `openstudio run -w workflow/template-run-hpxml-with-stochastic-occupancy.osw` When adding domain validation, I messed up the logic
Fix #4656 - E+ 22.2.0: Wrap Chiller:Electric:ASHRAE205
Update EnergyPlus to v22.2.0
…face Rendering Name
…s for Office_With_Many_HVAC_Types.idf
3d4c4bf to
8a2e6b4
Compare
… Air Fan Op Sched to always off to try and limit deviation
Volume, CeilingHeight, FloorArea for Space object, try 2
Collaborator
|
@joseph-robertson @tijcolem I fixed up a few things in the last commits and now tests should all be passing. Letting CI run on it, but if green let's merge to develop |
Collaborator
|
I need to modify the ChillerElectricASHRAE205 tests to avoid them copying/deleting the same path/copied cbor file so they don't fail when run in parallel. |
Collaborator
|
CI Results for f6af133:
|
Collaborator
|
Not going to wait 4 hours for windows to come in. I'm merging this but I'll check on the windows runner later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
Pull Request Author
src/model/test)src/energyplus/Test)src/osversion/VersionTranslator.cpp)Labels:
IDDChangeAPIChangePull Request - Ready for CIso that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.