Volume, CeilingHeight, FloorArea for Space object#4661
Merged
jmarrec merged 9 commits intov22.2.0-IOFreezefrom Sep 15, 2022
Merged
Volume, CeilingHeight, FloorArea for Space object#4661jmarrec merged 9 commits intov22.2.0-IOFreezefrom
jmarrec merged 9 commits intov22.2.0-IOFreezefrom
Conversation
17 tasks
jmarrec
reviewed
Sep 1, 2022
Comment on lines
5435
to
5449
| N5, \field Volume | ||
| \type real | ||
| \units m3 | ||
| \autocalculatable | ||
| \default autocalculate | ||
| N6, \field Ceiling Height | ||
| \type real | ||
| \units m | ||
| \autocalculatable | ||
| \default autocalculate | ||
| N7; \field Floor Area | ||
| \type real | ||
| \units m2 | ||
| \autocalculatable | ||
| \default autocalculate |
Collaborator
There was a problem hiding this comment.
(Side note; no action required: I know you're following the Volume pattern, though I think I would rather have it as \required-field and hardset to "Autocalculate" in the ctor)
Collaborator
|
CI Results for 2ab883c:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
Volume,CeilingHeight, andFloorAreaPull Request Author
src/model/test)src/energyplus/Test)src/osversion/VersionTranslator.cpp)Labels:
IDDChangeAPIChangePull Request - Ready for CIso that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.