Addresses #4646, wrap E+ 22.2 new supplemental heating coil type for AirLoopHVAC:UnitarySystem object#4666
Merged
jmarrec merged 60 commits intov22.2.0-IOFreezefrom Sep 26, 2022
Merged
Conversation
joseph-robertson
added
the
Pull Request - Ready for CI
17 tasks
joseph-robertson
added
the
APIChange
23 tasks
jmarrec
requested changes
Sep 21, 2022
| } // namespace detail | ||
|
|
||
| /** CoilCoolingDXMultiSpeedStageData is a ModelObject that wraps the OpenStudio IDD object 'OS:Coil:Cooling:DX:MultiSpeed:StageData'. */ | ||
| /** CoilCoolingDXMultiSpeedStageData is a ParentObject that wraps the OpenStudio IDD object 'OS:Coil:Cooling:DX:MultiSpeed:StageData'. */ |
Collaborator
There was a problem hiding this comment.
This one is, it has curves
| CoilHeatingElectricMultiStageStageData_Impl::CoilHeatingElectricMultiStageStageData_Impl(const IdfObject& idfObject, Model_Impl* model, | ||
| bool keepHandle) | ||
| : ModelObject_Impl(idfObject, model, keepHandle) { | ||
| : ParentObject_Impl(idfObject, model, keepHandle) { |
| /** CoilHeatingGasMultiStageStageData is a ModelObject that wraps the OpenStudio IDD object 'OS:Coil:Heating:Gas:MultiStage:StageData'. */ | ||
| class MODEL_API CoilHeatingGasMultiStageStageData : public ModelObject | ||
| /** CoilHeatingGasMultiStageStageData is a ParentObject that wraps the OpenStudio IDD object 'OS:Coil:Heating:Gas:MultiStage:StageData'. */ | ||
| class MODEL_API CoilHeatingGasMultiStageStageData : public ParentObject |
They do not bear any children (much less ResourceObject children) so they shouldn't be ParentObjects.
Collaborator
|
CI Results for a948f15:
|
Collaborator
|
@joseph-robertson I pushed a few changes. I put the CoilHeatingElectricMultiStageStageData and CoilHeatingGasMultiStageStageData back to ModelObject. I extended testing by quite a bit. I fixed the clone method for both. This can merge as far as I'm concerned. I also adjusted NatLabRockies/OpenStudio-resources#176 (and added it to the the PR Author checklist in your original post for clarity) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
AirLoopHVAC:UnitarySystemobject #4646Coil:Heating:Gas:MultiStage(appears possibly some issues with FT fromAirLoopHVAC:UnitarySystemandAirLoopHVAC:UnitaryHeatPump:AirToAir:MultiSpeed)Coil:Heating:Gas:MultiStageby making Availability Schedule required. Creates VT rules to handle this.Pull Request Author
src/model/test)src/energyplus/Test)src/osversion/VersionTranslator.cpp)Labels:
IDDChangeAPIChangePull Request - Ready for CIso that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.