Skip to content

Comments

Fix #4645 - Update FT for space-level infiltration/ventilation objects (E+ 22.2.0-IOFreeze)#4672

Merged
jmarrec merged 5 commits intov22.2.0-IOFreezefrom
4645_Infltration_to_Space
Sep 14, 2022
Merged

Fix #4645 - Update FT for space-level infiltration/ventilation objects (E+ 22.2.0-IOFreeze)#4672
jmarrec merged 5 commits intov22.2.0-IOFreezefrom
4645_Infltration_to_Space

Conversation

@jmarrec
Copy link
Collaborator

@jmarrec jmarrec commented Sep 8, 2022

Pull request overview

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

SpaceLoadInstance is a SpaceLoad. But SpaceInfiltrationDesignFlowRate is a SpaceLoad, not a SpaceLoadInstance
@jmarrec jmarrec force-pushed the 4645_Infltration_to_Space branch from c2bf505 to be67d32 Compare September 8, 2022 12:39
@jmarrec jmarrec mentioned this pull request Sep 8, 2022
17 tasks
@joseph-robertson joseph-robertson linked an issue Sep 9, 2022 that may be closed by this pull request
@tijcolem tijcolem added this to the OpenStudio SDK 3.5.0 milestone Sep 9, 2022
@joseph-robertson joseph-robertson added the Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. label Sep 12, 2022
@shorowit
Copy link
Contributor

I tested this for our use case and it seems to be working as expected.

@jmarrec jmarrec merged commit 4ede343 into v22.2.0-IOFreeze Sep 14, 2022
@jmarrec jmarrec deleted the 4645_Infltration_to_Space branch September 14, 2022 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component - IDF Translation Enhancement Request Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update FT for space-level infiltration/ventilation objects

5 participants