Fix #4648 #4654 - SurfaceProperty:GroundSurfaces and SurfaceProperty:IncidentSolarMultiplier#4676
Merged
jmarrec merged 22 commits intov22.2.0-IOFreezefrom Sep 15, 2022
Merged
Conversation
…nd SurfaceProperty:IncidentSolarMultiplier
…lier and SurfacePropertyGroundSurfaces
… optional or default to alwaysOnContinuous
…acePropertyGroundSurfaces
…_SurfaceProperties
…ultiplier as duplicated
…bSurface as early as possible.
jmarrec
added a commit
to NatLabRockies/OpenStudio-resources
that referenced
this pull request
Sep 12, 2022
…perty:GroundSurfaces Ref NatLabRockies/OpenStudio#4676
23 tasks
joseph-robertson
added
the
Pull Request - Ready for CI
Collaborator
|
CI Results for 111288a:
|
Contributor
|
I tested the IncidentSolarMultiplier object w/ a schedule and it worked as expected. |
| {"SurfacePropertyGroundSurfaces", "Ground Surface Temperature Schedule", "groundSurfaceTemperatureSchedule", true, "Temperature", | ||
| OptionalDouble(), OptionalDouble()}, | ||
| {"SurfacePropertyGroundSurfaces", "Ground Surface Reflectance Schedule", "groundSurfaceReflectanceSchedule", true, "", 0.0, 1.0}, | ||
| {"SurfacePropertyIncidentSolarMultiplier", "Incident Solar Multiplier", "incidentSolarMultiplierSchedule", true, "", 0.0, 1.0}, |
Collaborator
There was a problem hiding this comment.
"Incident Solar Multiplier Schedule"?
Collaborator
Author
There was a problem hiding this comment.
It's a mixed bad in schedule. Sometimes you have schedule, sometimes you don't, and it doesn't matter as long as the Class.cpp file matches the ScheduleTypeRegistry. That being said generateclass.rb omits the 'Schedule' part. The GroundSurfaces one I did manually... I'll remove the 'Schedule'.
| {"SurfacePropertySurroundingSurfaces", "Sky Temperature", "skyTemperatureSchedule", true, "Temperature", OptionalDouble(), OptionalDouble()}, | ||
| {"SurfacePropertySurroundingSurfaces", "Ground Temperature", "groundTemperatureSchedule", true, "Temperature", OptionalDouble(), | ||
| OptionalDouble()}, | ||
| {"SurfacePropertySurroundingSurfaces", "Surrounding Surface Temperature Schedule", "surroundingSurfaceTemperatureSchedule", true, "Temperature", |
Collaborator
There was a problem hiding this comment.
This one was just missing from before? Nice catch.
| std::vector<std::string> validAirInletConnectionTypes(definition.validAirInletConnectionTypeValues()); | ||
| EXPECT_NE(std::find(validAirInletConnectionTypes.begin(), validAirInletConnectionTypes.end(), "AdjustedSupply"), validAirInletConnectionTypes.end()); | ||
| EXPECT_NE(std::find(validAirInletConnectionTypes.begin(), validAirInletConnectionTypes.end(), "AdjustedSupply"), | ||
| validAirInletConnectionTypes.end()); |
Collaborator
There was a problem hiding this comment.
Unrelated leftover formatting.
This was referenced Sep 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
SurfaceProperty:IncidentSolarMultiplierobject #4648SurfaceProperty:GroundSurfacesobject #4654Pull Request Author
src/model/test)src/energyplus/Test)src/osversion/VersionTranslator.cpp)Labels:
IDDChangeAPIChangePull Request - Ready for CIso that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.