Skip to content

Fix AirLoopHVACUnitarySystem FT issues with UnitarySystemPerformanceMultispeed #5278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joseph-robertson merged 11 commits into from
Oct 29, 2024
Merged

Fix AirLoopHVACUnitarySystem FT issues with UnitarySystemPerformanceMultispeed #5278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b30c7c3
Add ft test file for UnitarySystemPerformanceMultispeed.
joseph-robertson Oct 24, 2024
132f0ec
Formatting.
joseph-robertson Oct 24, 2024
9c6c1e9
Clean up new test file.
joseph-robertson Oct 24, 2024
40e8dd9
Missed ft in the new test.
joseph-robertson Oct 24, 2024
d2ffafc
Create more test scenarios in new ft test file.
joseph-robertson Oct 28, 2024
1a12ffd
Use only multispeed objects.
joseph-robertson Oct 28, 2024
a1607fb
Check speed supply air flow ratio fields.
joseph-robertson Oct 28, 2024
e96e201
Set values for stage and unitary flow.
joseph-robertson Oct 29, 2024
918b025
Typo.
joseph-robertson Oct 29, 2024
c4acaab
Try a fix.
joseph-robertson Oct 29, 2024
4a3deb3
Test with 2 heating stages and 4 cooling stages + Scope test variable…
jmarrec Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/energyplus/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -829,6 +829,7 @@ set(${target_name}_test_src
Test/ThermalStorageChilledWaterStratified_GTest.cpp
Test/ThermalZone_GTest.cpp
Test/ThermostatSetpointDualSetpoint_GTest.cpp
Test/UnitarySystemPerformanceMultispeed_GTest.cpp
Test/WindowPropertyFrameAndDivider_GTest.cpp
Test/WaterHeaterMixed_GTest.cpp
Test/WaterHeaterSizing_GTest.cpp
Expand Down
37 changes: 19 additions & 18 deletions src/energyplus/ForwardTranslator/ForwardTranslateAirLoopHVACUnitarySystem.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,7 +456,8 @@ namespace energyplus {
boost::optional<model::CoilCoolingDXVariableSpeed> varSpeedDXCooling;
boost::optional<model::CoilCoolingWaterToAirHeatPumpVariableSpeedEquationFit> varSpeedWaterToAirCooling;

int maxStages = 0;
int maxHeatingStages = 0;
int maxCoolingStages = 0;

if (heatingCoil) {
multispeedDXHeating = heatingCoil->optionalCast<model::CoilHeatingDXMultiSpeed>();
Expand All @@ -482,36 +483,36 @@ namespace energyplus {

if (multispeedDXHeating) {
heatingStages = multispeedDXHeating->stages();
maxStages = heatingStages.size();
_unitarySystemPerformance.setInt(UnitarySystemPerformance_MultispeedFields::NumberofSpeedsforHeating, maxStages);
maxHeatingStages = heatingStages.size();
_unitarySystemPerformance.setInt(UnitarySystemPerformance_MultispeedFields::NumberofSpeedsforHeating, maxHeatingStages);
} else if (varSpeedDXHeating) {
varHeatingStages = varSpeedDXHeating->speeds();
maxStages = varHeatingStages.size();
_unitarySystemPerformance.setInt(UnitarySystemPerformance_MultispeedFields::NumberofSpeedsforHeating, maxStages);
maxHeatingStages = varHeatingStages.size();
_unitarySystemPerformance.setInt(UnitarySystemPerformance_MultispeedFields::NumberofSpeedsforHeating, maxHeatingStages);
} else if (multistageGasHeating) {
gasHeatingStages = multistageGasHeating->stages();
maxStages = gasHeatingStages.size();
_unitarySystemPerformance.setInt(UnitarySystemPerformance_MultispeedFields::NumberofSpeedsforHeating, maxStages);
maxHeatingStages = gasHeatingStages.size();
_unitarySystemPerformance.setInt(UnitarySystemPerformance_MultispeedFields::NumberofSpeedsforHeating, maxHeatingStages);
} else if (varSpeedWaterToAirHeating) {
waterToAirHeatingStages = varSpeedWaterToAirHeating->speeds();
maxStages = waterToAirHeatingStages.size();
_unitarySystemPerformance.setInt(UnitarySystemPerformance_MultispeedFields::NumberofSpeedsforHeating, maxStages);
maxHeatingStages = waterToAirHeatingStages.size();
_unitarySystemPerformance.setInt(UnitarySystemPerformance_MultispeedFields::NumberofSpeedsforHeating, maxHeatingStages);
} else {
_unitarySystemPerformance.setInt(UnitarySystemPerformance_MultispeedFields::NumberofSpeedsforHeating, 1);
}

if (multispeedDXCooling) {
coolingStages = multispeedDXCooling->stages();
maxStages = coolingStages.size();
Copy link
Collaborator Author

@joseph-robertson joseph-robertson Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was overwriting maxStages set by heating speeds.

_unitarySystemPerformance.setInt(UnitarySystemPerformance_MultispeedFields::NumberofSpeedsforCooling, maxStages);
maxCoolingStages = coolingStages.size();
_unitarySystemPerformance.setInt(UnitarySystemPerformance_MultispeedFields::NumberofSpeedsforCooling, maxCoolingStages);
} else if (varSpeedDXCooling) {
varCoolingStages = varSpeedDXCooling->speeds();
maxStages = varCoolingStages.size();
_unitarySystemPerformance.setInt(UnitarySystemPerformance_MultispeedFields::NumberofSpeedsforCooling, maxStages);
maxCoolingStages = varCoolingStages.size();
_unitarySystemPerformance.setInt(UnitarySystemPerformance_MultispeedFields::NumberofSpeedsforCooling, maxCoolingStages);
} else if (varSpeedWaterToAirCooling) {
waterToAirCoolingStages = varSpeedWaterToAirCooling->speeds();
maxStages = waterToAirCoolingStages.size();
_unitarySystemPerformance.setInt(UnitarySystemPerformance_MultispeedFields::NumberofSpeedsforCooling, maxStages);
maxCoolingStages = waterToAirCoolingStages.size();
_unitarySystemPerformance.setInt(UnitarySystemPerformance_MultispeedFields::NumberofSpeedsforCooling, maxCoolingStages);
} else {
_unitarySystemPerformance.setInt(UnitarySystemPerformance_MultispeedFields::NumberofSpeedsforCooling, 1);
}
Expand All @@ -529,7 +530,7 @@ namespace energyplus {
}
};

for (int i = 0; i < maxStages; ++i) {
for (int i = 0; i < std::max(maxHeatingStages, maxCoolingStages); ++i) {
auto extensible = _unitarySystemPerformance.pushExtensibleGroup();

if (static_cast<unsigned>(i) < heatingStages.size()) {
Expand Down Expand Up @@ -566,7 +567,7 @@ namespace energyplus {
} else {
extensible.setString(UnitarySystemPerformance_MultispeedExtensibleFields::HeatingSpeedSupplyAirFlowRatio, "Autosize");
}
} else if (i < 2) {
Copy link
Collaborator Author

@joseph-robertson joseph-robertson Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure the purpose of the "< 2"...?

} else {
extensible.setDouble(UnitarySystemPerformance_MultispeedExtensibleFields::HeatingSpeedSupplyAirFlowRatio, 1.0);
}

Expand Down Expand Up @@ -595,7 +596,7 @@ namespace energyplus {
} else {
extensible.setString(UnitarySystemPerformance_MultispeedExtensibleFields::CoolingSpeedSupplyAirFlowRatio, "Autosize");
}
} else if (i < 2) {
} else {
extensible.setDouble(UnitarySystemPerformance_MultispeedExtensibleFields::CoolingSpeedSupplyAirFlowRatio, 1.0);
}
}
Expand Down
Loading