#5350 - Changes to Support CoilSystem:Cooling:Water #5404

Merged

jmarrec merged 16 commits intocoilsystem-cooling-waterfrom

coilsystem-cooling-water2

May 5, 2025

Commits on May 5, 2025

Make the coolingCoil/companion return a HVACComponent + restrict the companion to CoilCoolingWater per IDD/IO ref
jmarrec
committed
Improve model gtests
jmarrec
committed
Test Explicit Ctor, including wrong cooling coil type + fixup explicit ctor to remove() and LOG_AND_THROW
jmarrec
committed
Remove useless optionalCompanionCoilUsedForHeatRecovery
jmarrec
committed
CoilSystemCoolingWaterHXAssisted:containingHVACComponent picks up CoilSystemCoolingWater
jmarrec
committed
Extend testing to ensure that remove works in particular
jmarrec
committed
Override remove() for CoilSystemCoolingWaterXX objects: need to disconnect the water side for the children coils
jmarrec
committed
Fixup the creation of the ControllerWaterCoil and disallow connection of the primary cooling cooling of a CoilSystemCoolingWater to an AirLoopHVAC
jmarrec
committed
I have no reason to believe that CoilSystemCoolingWater would be allowed anywhere in a ZoneHVAC/HVACComponent
jmarrec
committed
Adjust FT test after changing return type, and remove the Unitary test (not supported AFAIK)
jmarrec
committed
Remove unneeded bit in ForwardTranslateAirLoopHVAC
jmarrec
committed
Add a private assignEnergyPlusIDDDefaults method to avoid repeating code (and getting them out of sync) in both ctors
jmarrec
committed
Adjust FT Test: name the nodes and co, and test the relief node that has a FIXME (it fails)
jmarrec
committed
Fixup the FIXME
jmarrec
committed
Add a FT Gtest for a Case with a CoilSystemWaterHXAssisted inside a CoilSystemWater
jmarrec
committed
Fixup FT to handle CoilSystemWaterHXAssisted inside CoilSystemWater
jmarrec
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#5350 - Changes to Support CoilSystem:Cooling:Water #5404

#5350 - Changes to Support CoilSystem:Cooling:Water #5404
jmarrec merged 16 commits intocoilsystem-cooling-waterfrom
coilsystem-cooling-water2

Commits on May 5, 2025

Make the coolingCoil/companion return a HVACComponent + restrict the companion to CoilCoolingWater per IDD/IO ref

Improve model gtests

Test Explicit Ctor, including wrong cooling coil type + fixup explicit ctor to remove() and LOG_AND_THROW

Remove useless optionalCompanionCoilUsedForHeatRecovery

CoilSystemCoolingWaterHXAssisted:containingHVACComponent picks up CoilSystemCoolingWater

Extend testing to ensure that remove works in particular

Override remove() for CoilSystemCoolingWaterXX objects: need to disconnect the water side for the children coils

Fixup the creation of the ControllerWaterCoil and disallow connection of the primary cooling cooling of a CoilSystemCoolingWater to an AirLoopHVAC

I have no reason to believe that CoilSystemCoolingWater would be allowed anywhere in a ZoneHVAC/HVACComponent

Adjust FT test after changing return type, and remove the Unitary test (not supported AFAIK)

Remove unneeded bit in ForwardTranslateAirLoopHVAC

Add a private assignEnergyPlusIDDDefaults method to avoid repeating code (and getting them out of sync) in both ctors

Adjust FT Test: name the nodes and co, and test the relief node that has a FIXME (it fails)

Fixup the FIXME

Add a FT Gtest for a Case with a CoilSystemWaterHXAssisted inside a CoilSystemWater

Fixup FT to handle CoilSystemWaterHXAssisted inside CoilSystemWater