Merged
Conversation
…onsive reopt sizing progress dialog
Improve UI callback messages
cpaulgilman
approved these changes
Aug 8, 2024
Collaborator
cpaulgilman
left a comment
cpaulgilman
left a comment
There was a problem hiding this comment.
Thanks for finding and fixing the issue with progress bars.
I increased the delay between REopt API status checks to account for long optimization run times for Default PV-Battery / Commercial case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@cpaulgilman has completed all the work.
Update fcall_reopt_size_battery to dismiss simulation dialog and responsive reopt sizing progress dialog
Issue was wxWidget update to wxProgressDialog was blocking simulation dialog destruction and closing the reopt api dialog before the api call to v3 had completed.
Note that the PV-battery / Commercial default case resets progress bar from 99% to 98% about 5 times.
Note that the PV-battery / Residential default case completes with the progress bar at about 33%.
Details in attached Word document.
REopt2024.8.7_SAM_issue_1830.docx.zip