Conversation
This is not ideal, but until discrepancy is resolved on API side this works for SAM.
reverts changes from b26cce6
sjanzou
approved these changes
Nov 11, 2024
Collaborator
sjanzou
left a comment
sjanzou
left a comment
There was a problem hiding this comment.
Working on RedHat Linux
| "\tur_ec_tou_mat_original = value('ur_ec_tou_mat');\r", | ||
| "\t\r", | ||
| "\t// set energy and demand tier max value to 1e14 to avoid issue with HiGHS optimization\r", | ||
| "\ttier_max = 1e14;\r", |
Collaborator
There was a problem hiding this comment.
Thanks for catching and updating
cpaulgilman
added
added to release notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Goes with:
Requires SAM-private build to test (or modifying private.h to add NREL Developer API key in open source build).
Description
Use "stable" version of REopt API instead of "v3" in webapis.conf file to avoid issue with API returning empty string instead of run_uuid. Note we would prefer to use "v3" to ensure that SAM works when "stable" is updated, but until "stable" and "v3" generate the same results, this is not possible.
Temporarily set maximum tier values to 1e14 in UI before REopt API call because HiGHS solver doesn't work with numbers in vectors greater than 1e15. See https://ergo-code.github.io/HiGHS/dev/options/definitions/#large_matrix_value
Fix for both PV-Battery and PVWatts-Battery (simple).
Test on Mac and confirm same results on Mac and Windows.
Fixes #1830
Type of change
Please delete options that are not relevant.
Checklist:
If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.