use ET timezone consistently in the admin UI #693
+48
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves 18F/api.data.gov#695
The code here utilizes the pre-existing
format_iso8601_msand removes theformat_csvformat. I suppose that a compromise could be made to create a new format that is more like the csv format being depricated, but I figured it'd be nicer to just have less formats to worry about and reuse one we're already using.In the JS, just added some specifics to Parse the timezone as ET and add the timezone to the format string that's being shown to users.
Also adds a couple new tests for these changes.