Improve floris dataframe interpolation function#124
Merged
misi9170 merged 1 commit intoNatLabRockies:developfrom Dec 4, 2023
Merged
Conversation
…nts to replace manually adding rows with pd.concat() function. Significant speed-ups achieved.
misi9170
approved these changes
Dec 1, 2023
Collaborator
There was a problem hiding this comment.
Looks fine to me---I've run a couple of examples and seen no issues, and happy to take your word for speed ups for your internal process. @paulf81, any objections? Otherwise, I think we can merge.
Sorry that we've left this sitting a while---bit of a hectic couple of months...
Collaborator
|
Yes, ok for me too to merge. Thank you for checking @misi9170 and thanks for the submission @Bartdoekemeijer |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is ready to be merged.
Feature or improvement description
Split interpolation into 2D and 3D grid, and general pandas improvements to replace manually adding rows with pd.concat() function. Significant speed-ups achieved.
Related issue, if one exists
N/A
Impacted areas of the software
floris_toolsAdditional supporting information
Found a significant speed-up with in-house work. Found it hard to reproduce, but see code below:
Test results, if applicable
Here's a minimal example to reproduce:
This times at 41 seconds with the new code, and 50 seconds in the old code. So about a 20% improvement in this simplified example. Found a factor 3-4 speed-up in my in-house codes though.