Merged
Conversation
Collaborator
|
Nice feature! |
…r both velocity and deflection models.
misi9170
approved these changes
Dec 5, 2023
Collaborator
Author
|
Thanks you @misi9170 ! Merging now... |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think ready to be merged
Feature or improvement description
This feature adds a small convenience function that, given the time in a dataframe in UTC and a lat/long coordinate, adds a column to the dataframe is_day that can be used to partition the data into daytime and nighttime. The determination is made using the altitude of the sun calculated via python's ephem package. An option input, lag_hours, allows day/night to start a specified number of hours after sunrise/sunset.
The pull request includes an example using the smarteole data, and a new test.
Impacted areas of the software
dataframe_manipulations.py