Skip to content

Basic Floris v4 compatibility#169

Merged
misi9170 merged 21 commits intoNatLabRockies:v2from
misi9170:v2-ms/basic-florisv4-compatibility
Feb 8, 2024
Merged

Basic Floris v4 compatibility#169
misi9170 merged 21 commits intoNatLabRockies:v2from
misi9170:v2-ms/basic-florisv4-compatibility

Conversation

@misi9170
Copy link
Collaborator

@misi9170 misi9170 commented Feb 7, 2024

FLASC v2 will be released with FLORIS v4. This pull request ensures that, at this time, the v2 branch of FLASC is consistent with FLORIS v4 (still in development). Further fixes may be needed as FLORIS v4 is developed. Also, this PR only implements basic consistency---new features of FLORIS v4 are not exploited, but I have called out places that can likely exploit new functionalities (to be addressed in a separate PR), especially calc_floris_approx_table() in flasc/utilities/floris_tools.py.

Fixes the failing tests created by #165

I've also updated the example inputs. Note that FLORIS's ParallelComputingInterface is yet to be updated for FLORIS v4, so I've opted to use the FlorisInterface instead when creating approximate FLORIS solutions. However, this appears to be fast, so the ParallelComputingInterface may not be needed?

Checklist

  • Tests pass
  • artificial data examples run
  • Smarteole examples run

Exceptions

  • Yaw optimization codes don't run, since not yet updated in FLORIS v4

@misi9170 misi9170 requested a review from paulf81 February 7, 2024 20:37
@paulf81
Copy link
Collaborator

paulf81 commented Feb 7, 2024

I'm running through the examples now and finding little things to fix here and there, but wanted to flag a few things:

  1. I'm realizing flasc is under-tested, too many examples are failing despite passing tests, something for future work
  2. The examples in examples_artificial_data/02_wake_steering_design, I might wait to fix until the relavent optimization improvements are in floris v4

@paulf81
Copy link
Collaborator

paulf81 commented Feb 7, 2024

Adding to previous list of things to revisit:

  1. I'm realizing flasc is under-tested, too many examples are failing despite passing tests, something for future work

  2. The examples in examples_artificial_data/02_wake_steering_design, I might wait to fix until the relavent optimization improvements are in floris v4

  3. the linear interp in plot_layout in energy_ratio_het...mapper.py is failing in example 05

@paulf81
Copy link
Collaborator

paulf81 commented Feb 8, 2024

Ok @misi9170 I think (almost) all the examples are now updated to FLORIS v4. The ones with remaining issues I put seperate tracking issues for:

Issue #170
Issue #171

This one is good to merge from my perspective now

Copy link
Collaborator

@paulf81 paulf81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge

@misi9170 misi9170 merged commit 1d05ec6 into NatLabRockies:v2 Feb 8, 2024
@misi9170 misi9170 deleted the v2-ms/basic-florisv4-compatibility branch February 8, 2024 23:41
@misi9170 misi9170 mentioned this pull request Apr 10, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants