Basic Floris v4 compatibility#169
Merged
misi9170 merged 21 commits intoNatLabRockies:v2from Feb 8, 2024
Merged
Conversation
…DOs for better integration with FLORIS v4.
Collaborator
|
I'm running through the examples now and finding little things to fix here and there, but wanted to flag a few things:
|
Collaborator
|
Adding to previous list of things to revisit:
|
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FLASC v2 will be released with FLORIS v4. This pull request ensures that, at this time, the v2 branch of FLASC is consistent with FLORIS v4 (still in development). Further fixes may be needed as FLORIS v4 is developed. Also, this PR only implements basic consistency---new features of FLORIS v4 are not exploited, but I have called out places that can likely exploit new functionalities (to be addressed in a separate PR), especially
calc_floris_approx_table()in flasc/utilities/floris_tools.py.Fixes the failing tests created by #165
I've also updated the example inputs. Note that FLORIS's
ParallelComputingInterfaceis yet to be updated for FLORIS v4, so I've opted to use theFlorisInterfaceinstead when creating approximate FLORIS solutions. However, this appears to be fast, so theParallelComputingInterfacemay not be needed?Checklist
Exceptions