[BUGFIX] Fix stuck sensor detection only applying to last column#177
Merged
misi9170 merged 6 commits intoNatLabRockies:developfrom Mar 11, 2024
Merged
Conversation
e4c9e14 to
e319a1f
Compare
Collaborator
Author
|
Two of the examples (that I'm aware of) use
|
Collaborator
Author
|
Thanks @paulf81 . I realized I hadn't pushed the changes to the examples (not to the running code, just to the notebook output), so I'll do that now and then merge. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issue raised in #175.
The stuck sensor indices were only being returned for the last column checked, as opposed to a union of the indices over all columns. This PR addresses that issue.
To do
False, which whenTruewill instead return a dictionary containing a numpy array of stuck sensor indices for each column passed.@DanielKerrigan 's script below now produces the expected results