Change how number of turbines is counted#241
Merged
paulf81 merged 2 commits intoNatLabRockies:developfrom Dec 20, 2024
Merged
Conversation
ejsimley
approved these changes
Dec 19, 2024
Collaborator
ejsimley
left a comment
ejsimley
left a comment
There was a problem hiding this comment.
This works fine. However, I realized the code still assumes turbines are numbered sequentially when looping through turbines (e.g., for ti in range(self.n_turbines)). So maybe for now just stay with the sequential numbering requirement and we can update later if we decide it makes sense.
Collaborator
Author
|
Ok, do you have a preference? Merge this in as harmless or save for a more comprehensive change? |
Collaborator
Good question. I say merge now, but I'll add an issue so we can keep track of this topic. |
Collaborator
Author
|
Merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change how number of turbines is counted
The current method for counting the number of turbines uses a loop to see when the next turbine doesn't appear. This created an issue for a current project, where simply counting the number of columns that fit the pattern "pow_###" should provide the equivalent result and avoid the issue. This PR makes the change and adds a missing back test of the older
get_num_turbinesfunction.