Skip to content

Add CI branch for Python 3.8 and 3.10, update Ruff#648

Merged
rafmudaf merged 3 commits intoNatLabRockies:developfrom
rafmudaf:fixruff
May 7, 2023
Merged

Add CI branch for Python 3.8 and 3.10, update Ruff#648
rafmudaf merged 3 commits intoNatLabRockies:developfrom
rafmudaf:fixruff

Conversation

@rafmudaf
Copy link
Collaborator

@rafmudaf rafmudaf commented May 7, 2023

Expand CI coverage to include Python 3.8, 3.9, and 3.10

This pull request adds two more Python versions, 3.8 and 3.10, to the test matrix in addition to Python 3.9 for the automated testing GitHub Actions workflow that runs the unit tests, regression tests, and code coverage script. For the other GitHub Actions workflows, the Python version is upgraded to Python 3.10 from 3.9.

The motivation for this change is that we technically support these three versions of Python but we rarely actually use them. Most of the NREL team is on 3.9 or 3.10. Rather than installing 3.8 periodically to check, I prefer to offload this to the CI.

Upgrade Ruff adherence to v0.0.265

Lastly, formatting is fixed to support the latest version of Ruff, v0.0.265, but the minimum required version is not pinned.

Related issue

No open issue.

Impacted areas of the software

Formatting changes in some files, but otherwise this only impacts GitHub Actions configuration.

@rafmudaf rafmudaf added the enhancement An improvement of an existing feature label May 7, 2023
@rafmudaf rafmudaf added this to the v3.4 milestone May 7, 2023
@rafmudaf rafmudaf self-assigned this May 7, 2023
@rafmudaf rafmudaf merged commit 85dadb1 into NatLabRockies:develop May 7, 2023
@rafmudaf rafmudaf deleted the fixruff branch May 7, 2023 18:16
@paulf81
Copy link
Collaborator

paulf81 commented May 8, 2023

nice catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement An improvement of an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants