Add support for probing velocities at arbitrary flow field points#650
Merged
rafmudaf merged 34 commits intoNatLabRockies:developfrom May 10, 2023
Merged
Add support for probing velocities at arbitrary flow field points#650rafmudaf merged 34 commits intoNatLabRockies:developfrom
rafmudaf merged 34 commits intoNatLabRockies:developfrom
Conversation
This is ultimately used to construct the `power_interp` array, so it is redundant here.
Collaborator
Author
|
Ready for review. |
5 tasks
rafmudaf
reviewed
May 8, 2023
rafmudaf
reviewed
May 8, 2023
rafmudaf
reviewed
May 8, 2023
rafmudaf
reviewed
May 9, 2023
rafmudaf
reviewed
May 10, 2023
rafmudaf
force-pushed
the
feature/ps-basic
branch
from
c728bcd to
f8592b6
Compare
rafmudaf
approved these changes
May 10, 2023
rafmudaf
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ready for review
This pull request, based on the branch on @rafmudaf, adds the ability to collect the velocity at arbitrary points in space with the the new PointsGrid class. The feature is meant to be similar in some ways to visualization methods. This is similar to the draft pull request #641, but does not include the changes to
full_flow_sequential_solverand instead wraps around the existingfull_flow_sequential_solver. The downside of this is thatsequential_solveris called multiple times for no real benefit other than compatibility with existing code. Redesigning the code to handle both visualization and a point probe without repeating solves is left as a future task.To do: