Tw/aws pcluster example #575
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilliamsTravis
added
the
documentation
Collaborator
|
Will try to get around to this as soon as I can! At first glance, I don't think the data should be an issue since it's in the examples folder which should not be included with the python distribution that goes up on PyPi. The failing tests are likely due to Pandas 3.0. Unclear if we'll need/want to fix those before merging this PR. LMK if merging this is urgent though |
Collaborator
Author
|
Great, thanks! Yeah, I was surprised how picky the language linter was but got through those. I haven't dug into the errors yet, but Pandas 3.0 bugs makes sense. Hopefully, just constraining the versions will fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I have the updated AWS parallel cluster example/guide in this branch.
If this is too verbose, let me know, I have a full version saved elsewhere and can reduce this down. Also, I included some example project point files for convenience, but have a script to build them if we want to reduce the amount of data.
Is there anything else I need to do to make sure this is rendered properly in the docs?