Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FINNA-2838] Add Finna specific OAI metadata format #3097

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

LuomaJuha
Copy link

@LuomaJuha LuomaJuha commented Dec 3, 2024

Adds couple fields to be exposed in the OAI response.

Could also be possible to open this in upstream with options to allow additional prefixes, but think it could be maybe unnecessary?

Requires:

@LuomaJuha LuomaJuha requested review from EreMaijala and removed request for EreMaijala December 3, 2024 13:57
Copy link

@EreMaijala EreMaijala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tässä voisi olla hyötyä siitä, että yläjuoksulla tuo ensimmäinen blokki attachNonDeleted:stä irrotettaisiin omaksi metodiksi, jota attachNonDeleted kutsuu, niin ei tarvitsisi koko metodia yliajaa.

@@ -618,6 +640,18 @@ urls:
type: array
items:
$ref: '#/components/schemas/Url'
usageRights:
vufind.method: getUsageRights
description: Usage rights

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usage rights (see [usage_rights_str_mv at https://www.kiwi.fi/display/Finna/Kenttien+mappaukset+eri+formaateista+Finnan+indeksiin](https://github.com/NatLibFi/RecordManager-Finna/blob/dev/mappings/usage_rights.map.sample))

type: string
usageRightsExtended:
vufind.method: getUsageRightsExt
description: Usage rights extended

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extended usage rights (see https://github.com/NatLibFi/RecordManager-Finna/blob/dev/mappings/usage_rights_ext.map.sample)

@@ -975,7 +975,7 @@ url = https://www.myendnoteweb.com/EndNoteWeb.html
;set_query['eod_books'] = "institution:kfu AND publishDate:[1911 TO 1911]"
;set_query['eod_ebooks'] = "format:eBook"
;vufind_api_format_fields = "id,authors,cleanIsbn,cleanIssn,formats,title"

;finna_api_format_fields = "id,authors,cleanIsbn,cleanIssn,formats,title,images,mediaTypes,ctrlnum,institutions,year,recordFormat,sectors,majorGenres,usageRights,usageRightsExtended,measurements,collections"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tyhjä rivi takaisin ennen Proxy-sektiota.

// the supplied metadataPrefix is available.
// If RecordDriver returns nothing, skip this record.
if (empty($xml)) {
return true;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tämän pitäisi olla return false;

@LuomaJuha LuomaJuha added in progress upstream dependency If something is needed from the upstream and removed question labels Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress upstream dependency If something is needed from the upstream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants