Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show notations in hierarchy #264

Closed
osma opened this issue Jun 18, 2015 · 6 comments
Closed

Show notations in hierarchy #264

osma opened this issue Jun 18, 2015 · 6 comments
Labels
enhancement REST size-medium 2 hours to 2 days
Milestone
1.3

Comments

@osma
Copy link
Member

osma commented Jun 18, 2015

Currently notation codes (e.g. in PTVL and Iconclass) are shown only on the concept page.

For classification-style use, it would be useful to show them also in the hierarchy display. This probably needs an extension to the REST API so that notations are returned alongside labels in the hierarchy-related methods.
@osma osma added this to the Next Tasks milestone Jun 18, 2015
@osma osma mentioned this issue Jun 18, 2015
Closed
@osma
Copy link
Member Author

osma commented Sep 17, 2015

UDC Summary has a good implementation of this: http://www.udcc.org/udcsummary/php/index.php?lang=en

henriyli pushed a commit that referenced this issue Sep 21, 2015
adding notations to the hierarchy rest query and showing those in the…
1772b96 
… jstree, related to #264
@henriyli henriyli modified the milestones: 1.3, Next Tasks Sep 21, 2015
@henriyli henriyli reopened this Sep 24, 2015
henriyli pushed a commit that referenced this issue Sep 24, 2015
adding notations to the children rest method and support for this to …
64dea6b 
…the hierarchy view, related to #264
henriyli pushed a commit that referenced this issue Sep 24, 2015
adding notation to the context of the children json response, related…
a1e2615 
… to #264
@henriyli
Copy link
Collaborator

The topconcepts are now too properly displayed thanks to 276bda6

@henriyli henriyli reopened this Oct 26, 2015
@henriyli
Copy link
Collaborator

The concept hierarchy doesn't seem to be finding broader siblings. And there is something wrong with the top concepts too. See: http://dev.finto.fi/ptvl/fi/page/?uri=http%3A%2F%2Furn.fi%2FURN%3ANBN%3Afi%3Aau%3Aptvl%3ATT1.1

henriyli pushed a commit that referenced this issue Oct 28, 2015
related to #264
feca856
@henriyli
Copy link
Collaborator

This should now work. af743b1

@osma
Copy link
Member Author

osma commented Oct 29, 2015

Should document on the REST API wiki page that some of the methods also return notation.

@osma osma reopened this Oct 29, 2015
@henriyli
Copy link
Collaborator

The documentation has now been updated.

@jarmosaarikko jarmosaarikko mentioned this issue Mar 13, 2019
Closed
@jarmosaarikko jarmosaarikko mentioned this issue Oct 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement REST size-medium 2 hours to 2 days
Projects
None yet
Milestone
1.3
Development

No branches or pull requests
2 participants
@osma @henriyli