Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search doesn't match via altLabel if there is no prefLabel with the same language tag #3

Closed
osma opened this issue Jun 17, 2014 · 2 comments
Assignees
Labels
Milestone

Comments

@osma
Copy link
Member

osma commented Jun 17, 2014

Copied from: https://code.google.com/p/onki-light/issues/detail?id=297

At which URL did you encounter the problem?
http://dev.finto.fi/asteri-cn/fi/search?lang=&q=tammerfors

What steps will reproduce the problem?

  1. Search asteri-cn for "Tammerfors" in any language
    or
  2. Search asteri-cn for "City of Tampere" in any language

What is the expected output? What do you see instead?

Expect to get the result "Tampereen kaupunki". Instead getting an error about no hits.

The concept only has a prefLabel with @fi language tag. The altLabels are "Tampere" (no lang tag) and "City of Tampere"@en. These are not matched because of this part in the SPARQL query:

&& langMatches(lang(?label), lang(?match))

which requires the matched label to have the same language tag as (one of) the prefLabel(s).

@osma osma self-assigned this Jun 17, 2014
@osma osma added this to the 0.4 milestone Jun 17, 2014
@osma osma added the bug label Jun 17, 2014
@osma
Copy link
Member Author

osma commented Jun 17, 2014

Fixing this requires separating between UI language and search language in the Model code.

@osma
Copy link
Member Author

osma commented Jun 17, 2014

Still affects the REST API, and therefore the autocomplete search. The problem is that as currently defined, the REST search method only takes one lang parameter. Another parameter should be added in order to separate between UI language and search language.

@osma osma reopened this Jun 17, 2014
@osma osma closed this as completed in edd728e Jun 19, 2014
osma added a commit that referenced this issue Oct 7, 2015
osma added a commit that referenced this issue Oct 7, 2015
joelit pushed a commit that referenced this issue Feb 17, 2022
* Allow plugin robloach/component-installer, because it is required by components/handlebars.js

* Adding /.idea to .gitignore so project can be edited in IntelliJ

* Removed .idea files from PR

* newline at end of .gitignore

* Upgraded Twig

* Added composer.lock
joelit pushed a commit that referenced this issue Mar 2, 2022
* Allow plugin robloach/component-installer, because it is required by components/handlebars.js

* Adding /.idea to .gitignore so project can be edited in IntelliJ

* Removed .idea files from PR

* newline at end of .gitignore

* Upgraded Twig

* Added composer.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant