Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In ConceptPropertyValue.getLabel(), the $fallback parameter should have another name #880

Closed
tfrancart opened this issue Jul 29, 2019 · 0 comments · Fixed by #888 · May be fixed by #881
Closed

In ConceptPropertyValue.getLabel(), the $fallback parameter should have another name #880

tfrancart opened this issue Jul 29, 2019 · 0 comments · Fixed by #888 · May be fixed by #881
Milestone

Comments

@tfrancart
Copy link
Contributor

In https://github.com/NatLibFi/Skosmos/blob/master/model/ConceptPropertyValue.php#L38, the variable $fallback passed as a method parameter is overidden in the inner for loop to check for fallback languages. Hence the last test of the function if($fallback == 'uri') never works.

This causes problem when printing translated values of the "type" in Group pages, since this rely on this fallback mechanism to print the label of the entry type. See screenshot

image

The solution is to rename the parameter to something else than "fallback".

tfrancart pushed a commit to tfrancart/Skosmos that referenced this issue Jul 29, 2019
kouralex pushed a commit that referenced this issue Aug 21, 2019
kouralex added a commit that referenced this issue Sep 12, 2019
@osma osma added this to the 2.2 milestone Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants