Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid character in SMTP headers #936

Closed
ghost opened this issue Feb 20, 2020 · 1 comment · Fixed by #939
Closed

Invalid character in SMTP headers #936

ghost opened this issue Feb 20, 2020 · 1 comment · Fixed by #939

Comments

@ghost
Copy link

ghost commented Feb 20, 2020

This line of code
https://github.com/NatLibFi/Skosmos/blob/master/controller/WebController.php#L366
$headers = "MIME-Version: 1.0″ . '\r\n";
introduces an invalid quote that can cause SMTP servers to crash, as explained here :
https://groups.google.com/forum/#!topic/skosmos-users/2d6xTLNx4vg
It should be :
$headers = "MIME-Version: 1.0" . "\r\n";

@osma osma added the bug label Feb 24, 2020
@osma osma added this to the 2.4 milestone Feb 24, 2020
@osma
Copy link
Member

osma commented Feb 24, 2020

Thanks, good catch! Looking at git history, this bug has been in Skosmos since the project transitioned from SVN in 2014, so it's pretty ancient.

osma added a commit that referenced this issue Feb 24, 2020
@osma osma closed this as completed in #939 Feb 24, 2020
osma added a commit that referenced this issue Feb 24, 2020
(cherry picked from commit 083a989)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant