Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"counts" table in vocabulary page is missing class="table" #955

Closed
tfrancart opened this issue Mar 12, 2020 · 1 comment · Fixed by #956
Closed

"counts" table in vocabulary page is missing class="table" #955

tfrancart opened this issue Mar 12, 2020 · 1 comment · Fixed by #956
Assignees
Labels
Milestone

Comments

@tfrancart
Copy link
Contributor

At which URL did you encounter the problem?

http://erato.sparna.fr/skosmos-ar/thesaurus/en/

What steps will reproduce the problem?

  • Go to a vocabulary page.
  • In the HTML code, look for the <table id="counts"
  • it is missing the class="table"

This has a side-effect when displaying in Arabic, RTL.

What is the expected output? What do you see instead?

The table should have class="table", but also have a max-width=450px just like the table id="statistics" below it.

What browser did you use? (eg. Firefox, Chrome, Safari, Internet explorer)

@osma osma added the bug label Mar 12, 2020
@osma osma added this to the 2.4 milestone Mar 12, 2020
@osma
Copy link
Member

osma commented Mar 12, 2020

Thanks for the report. I tested the suggested change. Some other adjustments are needed as well, but those are doable. We're just about to release 2.4 but this is a relatively straightforward fix so I think it could go in...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants