Declare required PHP extensions using Composer #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #1008 +/- ##
=========================================
Coverage 60.29% 60.29%
Complexity 1592 1592
=========================================
Files 32 32
Lines 4425 4425
=========================================
Hits 2668 2668
Misses 1757 1757 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that only one required PHP extension (gettext) is declared via Composer, but there are actually several that Skosmos requires. So I added declarations for the others as well. I'm not sure this whether this is a complete list but at least it covers the cases that need to be installed from separate Debian/Ubuntu packages (as listed in the Install Tutorial section on installing PHP).