Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mappings: fix issue with explicitLanguageTags set to true and label i… #1012

Merged
merged 1 commit into from
Jun 23, 2020

Conversation

kouralex
Copy link
Contributor

…s just shortened property; fix property text help

There was an unidentified case of #990 which was tried to be fixed with #998.
Fixes #990 for good.

For testing, see http://dev.finto.fi/gfdc/en/page/C861 and http://www.yso.fi/onto/yso/p105695.

Also, fixes an issue where a help text (tooltip) for property is shown even though there is no translation for it. See for example http://dev.finto.fi/gfdc/en/page/C861 -> tooltip of 'Related Matching Concepts'.

…s just shortened property; fix property text help
@kouralex kouralex added this to the 2.7 milestone Jun 23, 2020
@kouralex kouralex requested a review from osma June 23, 2020 08:18
@sonarcloud
Copy link

sonarcloud bot commented Jun 23, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jun 23, 2020

Codecov Report

Merging #1012 into master will increase coverage by 0.03%.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1012      +/-   ##
============================================
+ Coverage     60.29%   60.32%   +0.03%     
- Complexity     1592     1593       +1     
============================================
  Files            32       32              
  Lines          4425     4429       +4     
============================================
+ Hits           2668     2672       +4     
  Misses         1757     1757              
Impacted Files Coverage Δ Complexity Δ
model/ConceptMappingPropertyValue.php 74.56% <83.33%> (+0.92%) 40.00 <0.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 258c04a...e0d4737. Read the comment docs.

Copy link
Member

@osma osma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK. I don't have time to test it locally but I trust that you've tried it for yourself.

@kouralex kouralex merged commit 653ad5e into master Jun 23, 2020
@osma osma deleted the issue990-fix-labelless-uris branch March 11, 2021 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AJAX-loaded mapped properties do not respect skosmos:explicitLanguage setting
2 participants