Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1027 by commenting out css file path #1028

Merged
merged 1 commit into from
Jul 10, 2020

Conversation

Vainonen
Copy link
Contributor

Comments out config.ttl.dist Skosmos custom CSS file path, which does not exist by default.

@Vainonen Vainonen requested a review from kouralex July 10, 2020 10:14
@sonarcloud
Copy link

sonarcloud bot commented Jul 10, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Jul 10, 2020

Codecov Report

Merging #1028 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1028   +/-   ##
=========================================
  Coverage     60.32%   60.32%           
  Complexity     1593     1593           
=========================================
  Files            32       32           
  Lines          4429     4429           
=========================================
  Hits           2672     2672           
  Misses         1757     1757           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e09706...760b217. Read the comment docs.

@kouralex kouralex merged commit 37601f9 into master Jul 10, 2020
@kouralex
Copy link
Contributor

Nice catch and good PR! I will gladly merge this.

@osma osma added this to the 2.8 milestone Oct 6, 2020
@osma osma deleted the issue1027-comment-out-custom-css branch March 11, 2021 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants