Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue1047 wcag more semantic headings #1061

Merged
merged 19 commits into from
Sep 17, 2020
Merged
Show file tree
Hide file tree
Changes from 18 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
033bf81
add screen reader class
kouralex Sep 3, 2020
78a4c72
Merge branch 'master' of https://github.com/NatLibFi/Skosmos into iss…
kouralex Sep 7, 2020
b55ae9e
WCAG: fix front page heading structure
kouralex Sep 7, 2020
1bf6585
Merge branch 'master' of https://github.com/NatLibFi/Skosmos into iss…
kouralex Sep 8, 2020
23680c4
add screen reader only heading to search
kouralex Sep 8, 2020
905091f
incorporating headings into vocabulary info page; started implementin…
kouralex Sep 8, 2020
2bdb48f
main sidebar + alphabetical listing now support heading navigation; y…
kouralex Sep 9, 2020
7f28e61
fix color and border issues in sidebar buttons
kouralex Sep 10, 2020
eca1b5c
changes subpage now support headings
kouralex Sep 11, 2020
5c645d2
add support for headings in groupings
kouralex Sep 11, 2020
61e2991
add headings to vocab.twig
kouralex Sep 11, 2020
245418d
relocated .sidebar-grey heading so that jstree does not interfere wit…
kouralex Sep 11, 2020
d775646
fix regressions encountered on vocabulary search page
kouralex Sep 13, 2020
8694291
fix css problem with '!*' in alphabetical listing spanning over two l…
kouralex Sep 14, 2020
b4002d1
add accessibility headings to search result page; addresses #1039
kouralex Sep 14, 2020
c24b11e
Merge branch 'master' of https://github.com/NatLibFi/Skosmos into iss…
kouralex Sep 14, 2020
c58d74d
fix regressions in vocabulary page; fix a bug introduced by using hea…
kouralex Sep 15, 2020
96e4276
concept info page to use headings; addresses #1038
kouralex Sep 15, 2020
c0f9976
fix screen reader explanation for changes tab
kouralex Sep 15, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
124 changes: 80 additions & 44 deletions resource/css/styles.css
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ h1, .prefLabel, .prefLabelLang, .notation {
font-weight: bold;
}

h2 {
h2, h3 {
font-family: 'Fira Sans', sans-serif;
font-size: 16px;
}
Expand Down Expand Up @@ -154,6 +154,19 @@ ul {
width: 25px;
}

/* Generic screen reader class
* Code from https://webaim.org/techniques/css/invisiblecontent/
***************************/

.sr-only {
position:absolute;
left:-10000px;
top:auto;
width:1px;
height:1px;
overflow:hidden;
}

/* topbar styles
***************************/

Expand Down Expand Up @@ -643,38 +656,29 @@ span.xl-pref-label > img {
width: 100% !important;
}

#vocabulary-list > div > h2, #vocabulary-list-wide > div > h2 {
#vocabulary-list > div > h2, #vocabulary-list > div > h3, #vocabulary-list-wide > div > h2, #vocabulary-list-wide > div > h3 {
margin-bottom: 0;
margin-top: 0;
padding: 15px 0 15px 10px;
}

.vocab-category {
display: inline-block;
padding-left: 0;
width: 100%;
}

.vocab-category > ul > li, .vocab-category > h2 {
.vocab-category > h3 {
display: inline-block;
}

.vocab-category > h2 {
margin: 0 0 5px 0;
}

.vocab-category > ul > li {
display: block;
}

.vocab-category > ul {
display: inline-block;
width: 72%;
float: right;
padding-left: 0;
}

.vocab-category > li > h2 {
.vocab-category > li > h3 {
margin-bottom: 5px;
margin-top: 0;
}
Expand Down Expand Up @@ -1065,6 +1069,10 @@ li.sub-group {
margin-bottom: 15px;
}

.download-links a {
margin-left: 5px;
}

.count-type {
padding-right: 20px;
}
Expand Down Expand Up @@ -1093,8 +1101,20 @@ li.sub-group {
right: 0;
}

.alert h2 {
.alert-danger {
font-size: 18px;
}

.content .alert-danger p {
color: #fff;
font-weight: 500;
margin: 5px 0 5px 0;
line-height: 1.1;
}

.search-result-listing .deprecated-alert {
margin-left: 10px;
color: #D95F8A;
}

.alert-replaced a {
Expand Down Expand Up @@ -1125,6 +1145,11 @@ li.sub-group {
margin-bottom: 20px;
}

.concept-info h3 {
margin: 0;
line-height: 22.85px;
}

.deprecated-concept * {
color: #888;
}
Expand All @@ -1151,10 +1176,6 @@ li.sub-group {
position: relative;
}

.logo-header {
padding-left: 18%;
}

.property-value-column > .row > .col-xs-5 > .versal {
word-wrap: break-word;
}
Expand Down Expand Up @@ -1331,6 +1352,22 @@ tr.replaced-by > td > ul > li > a {
padding-left: 0;
}

#vocab-info h2 {
font-size: 27px;
font-weight: 400;
}

#vocab-info h3 {
font-weight: 400;
display: initial;
}

#vocab-info > div > h3 {
font-weight: 500;
margin-bottom: 10px;
display: block;
}

#counts { max-width: 300px; }

#statistics { max-width: 450px; }
Expand Down Expand Up @@ -1358,8 +1395,9 @@ tr.replaced-by > td > ul > li > a {
width: 25px;
}

.pagination > li:last-child > a {
.pagination > li:nth-last-child(2) > a, .pagination > li:last-child > a {
width: auto;
min-width: 26px;
}

.pagination {
Expand All @@ -1371,7 +1409,7 @@ tr.replaced-by > td > ul > li > a {
width: 310px;
}

.nav-tabs, #groups > a {
.nav-tabs {
background-color: #e0e4e7;
border-bottom: none;
}
Expand All @@ -1380,7 +1418,7 @@ ul.nav-tabs > li {
margin-bottom: 0;
}

.nav-tabs > li > a, .nav-tabs > li > p, .nav-tabs > li.active > a, .nav-tabs > li.active > a:hover {
.sidebar-buttons .nav-tabs > li > a, .sidebar-buttons .nav-tabs > li > p, .sidebar-buttons .nav-tabs > li.active > a {
background-color: #e6e9eb;
border-radius: 0;
border: 0;
Expand All @@ -1389,8 +1427,23 @@ ul.nav-tabs > li {
text-align: center;
}

.nav-tabs > li:nth-of-type(even) > a {
background-color: #e0e4e7;
}

.nav-tabs > li:nth-of-type(odd) > a {
background-color: #e6e9eb;
}

.sidebar-buttons .nav-tabs > li.active > a {
background-color: #f6f7f8;
}

.sidebar-buttons .nav-tabs > li > a:hover {
background-color: white;
}

#limit {
margin-top: -1px;
width: 33%;
}

Expand All @@ -1402,9 +1455,6 @@ ul.nav-tabs > li {
width: 34%;
}

#alpha > a {
}

.nav-four-wide > li {
width: 28%;
}
Expand All @@ -1413,32 +1463,18 @@ ul.nav-tabs > li {
width: 16%;
}

.nav-tabs > li.active > a {
background-color: #f6f7f8;
}

#hierarchy-disabled > *, #hierarchy-disabled > *:hover {
background-color: #B9C1C6;
color: #74787A;
cursor: default;
}

#changes > a {
background-color: #DEDFE0;
}

.nav-tabs > *:hover {
background-color: #ffffff;
}


.change-list > span {
display: inline-block;
margin-top: 15px;
}

.change-list > span:first-of-type {
margin: 0;
.change-list > h5 {
margin-bottom: 2px;
}

.content {
Expand Down Expand Up @@ -1709,7 +1745,7 @@ p.autocomplete-label {
* https://code.google.com/p/chromium/issues/detail?id=336476
************************************/

body, .versal, h1, h2, p, .versal-bold {
body, .versal, h1, h2, h3, p, .versal-bold {
-webkit-animation-delay: 0.1s;
-webkit-animation-name: fontfix;
-webkit-animation-duration: 0.1s;
Expand Down Expand Up @@ -1786,10 +1822,10 @@ body, .versal, h1, h2, p, .versal-bold {
}

@media (max-width: 340px) {
#vocab-info .vocab-info-literals > table > tbody > tr > th {
#vocab-info .vocab-info-literals .property-label {
max-width: 120px;
}
#vocab-info .vocab-info-literals > table > tbody > tr > td {
#vocab-info .vocab-info-literals .property-value-column {
max-width: 180px;
}
}
Expand Down
Loading