Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix position of concept spinner, which was broken by a -moz-fit-width rule. #1071

Merged
merged 1 commit into from
Oct 2, 2020

Conversation

osma
Copy link
Member

@osma osma commented Oct 2, 2020

This was broken by a CSS rule introduced in #1067:

 .content {
   width: -moz-fit-content;
 }

I couldn't find any reason for this rule, as dropping it didn't seem to have any adverse effects but removing it fixes the position of the spinner displayed when loading a concept page takes a long time.

@osma osma added the bug label Oct 2, 2020
@osma osma added this to the 2.8 milestone Oct 2, 2020
@osma osma self-assigned this Oct 2, 2020
@osma osma merged commit b57dbae into master Oct 2, 2020
@sonarcloud
Copy link

sonarcloud bot commented Oct 2, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@osma osma deleted the fix-concept-spinner-placement branch February 17, 2021 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant