Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add treatment for JSON-LD vocabulary data dump; fixes #1096 #1097

Merged
merged 1 commit into from
Feb 17, 2021

Conversation

kouralex
Copy link
Contributor

This PR fixes #1096 via adding treatment for JSON-LD data dump.

After mergeing it might be a good idea to update https://github.com/NatLibFi/Skosmos/wiki/ServingLinkedData wiki page accordingly.

@kouralex kouralex added this to the 2.9 milestone Nov 30, 2020
@kouralex kouralex requested a review from joelit November 30, 2020 09:24
@sonarcloud
Copy link

sonarcloud bot commented Nov 30, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Nov 30, 2020

Codecov Report

Merging #1097 (fab8b80) into master (91a30e5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1097   +/-   ##
=========================================
  Coverage     60.32%   60.32%           
  Complexity     1592     1592           
=========================================
  Files            32       32           
  Lines          4429     4429           
=========================================
  Hits           2672     2672           
  Misses         1757     1757           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91a30e5...fab8b80. Read the comment docs.

@osma osma self-assigned this Feb 17, 2021
@osma
Copy link
Member

osma commented Feb 17, 2021

Tested locally, seems to work fine, merging away!

@osma osma merged commit f13ef7a into master Feb 17, 2021
@osma osma deleted the issue1096-add-jsonld-datadump-link branch February 17, 2021 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add link to JSON-LD data dump
2 participants