Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add isset tests to fix undefined index PHP notices in RestController #1102

Merged
merged 2 commits into from
Feb 17, 2021

Conversation

kouralex
Copy link
Contributor

@kouralex kouralex commented Dec 7, 2020

No description provided.

@kouralex kouralex added this to the Next Tasks milestone Dec 7, 2020
@kouralex kouralex requested review from joelit and osma December 7, 2020 12:55
@codecov
Copy link

codecov bot commented Dec 7, 2020

Codecov Report

Merging #1102 (1a123d8) into master (91a30e5) will increase coverage by 1.72%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1102      +/-   ##
============================================
+ Coverage     60.32%   62.05%   +1.72%     
- Complexity     1592     1626      +34     
============================================
  Files            32       32              
  Lines          4429     4654     +225     
============================================
+ Hits           2672     2888     +216     
- Misses         1757     1766       +9     
Impacted Files Coverage Δ Complexity Δ
controller/RestController.php 11.45% <0.00%> (ø) 193.00 <0.00> (+4.00)
model/sparql/GenericSparql.php 72.59% <0.00%> (+4.54%) 348.00% <0.00%> (+30.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91a30e5...1a123d8. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 7, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@osma osma self-assigned this Feb 17, 2021
@osma osma added bug and removed enhancement labels Feb 17, 2021
@osma osma modified the milestones: Next Tasks, 2.9 Feb 17, 2021
@osma
Copy link
Member

osma commented Feb 17, 2021

The Travis CI build failure was transient and only happened on PHP 7.2 not other versions, so I will ignore it. Looks good, merging.

@osma osma merged commit ba9ef89 into master Feb 17, 2021
@osma osma deleted the fix-undefined-index-preflabel-in-restcontroller branch February 17, 2021 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants