Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multilingual properties in case no hit in content lan… #1123

Conversation

miguelvaara
Copy link
Contributor

…guage; fixes #1115

@miguelvaara miguelvaara added this to the 2.9 milestone Feb 25, 2021
@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #1123 (5939f40) into master (dc9c72a) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1123      +/-   ##
============================================
+ Coverage     60.27%   60.30%   +0.02%     
- Complexity     1599     1600       +1     
============================================
  Files            32       32              
  Lines          4436     4436              
============================================
+ Hits           2674     2675       +1     
+ Misses         1762     1761       -1     
Impacted Files Coverage Δ Complexity Δ
model/Concept.php 79.70% <100.00%> (ø) 197.00 <0.00> (+1.00)
model/DataObject.php 78.04% <0.00%> (+2.43%) 23.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc9c72a...1acb473. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Feb 25, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 10 Security Hotspots
Code Smell A 8 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Vainonen
Copy link
Contributor

Hyperlinks in multilingual properties were not working, so I decided to add support for them.

Good work @miguelahonen & @kouralex ! I will merge this now.

@Vainonen Vainonen merged commit a4cb4dc into master Feb 25, 2021
@osma osma deleted the issue1115-MultiLingual-Property-Setting-Doesnt-Work-As-Intended branch March 11, 2021 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The skosmos:hasMultiLingualProperty setting doesn't work as intended
2 participants