-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to PHPUnit 8; bump required PHP to 7.2+; fix Travis tests on PHP 7.4 #1127
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1127 +/- ##
============================================
+ Coverage 60.38% 67.90% +7.52%
+ Complexity 1584 1583 -1
============================================
Files 32 32
Lines 4377 3889 -488
============================================
- Hits 2643 2641 -2
+ Misses 1734 1248 -486
Continue to review full report at Codecov.
|
Tests are still failing on PHP 7.4. I think EasyRdf needs to be upgraded first... |
EasyRdf update in PR #1128 needs to be merged first, then I can continue working on this PR. |
062f920
to
10a40ca
Compare
Rebased on current The PHPUnit 8 deprecation warnings should now be fixed; waiting for Travis CI tests to finish. |
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent PR! This indeed fixes Travis tests for PHP7.4. Testing with PHP 7.2, everything is working.
I did not notice any regressions in code changes, only improvements.
I will mark this PR ready for merging. Good job!
We have been using obsolete PHPUnit 7, which is not compatible with PHP 7.4 and is no longer supported.
This PR upgrades to PHPUnit 8, which is still supported (but only in Life Support mode).
It requires PHP 7.2, so this PR drops support for PHP 7.1 and attempts to get Travis CI tests working on PHP 7.4.
Some tests had to be modified (add void return types for setUp and tearDown methods) to keep PHPUnit 8 happy. There are warnings about deprecated PHPUnit features that should be addressed as well but they are not fatal (yet).
Fixes #920