A validation improved (solid red lines around the text fields in all … #1133
Conversation
…validated and failed cases). In addition, WCAG 2.1 AA level related global style definition for HTML label tag now applies only to feedback form
Codecov Report
@@ Coverage Diff @@
## master #1133 +/- ##
============================================
+ Coverage 60.30% 64.37% +4.06%
- Complexity 1602 1670 +68
============================================
Files 32 32
Lines 4439 4752 +313
============================================
+ Hits 2677 3059 +382
+ Misses 1762 1693 -69
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
I tested this locally and it looks like this when I try to submit an empty form:
Comments/requests:
- The color is now red. I suggest using the pinkish color Skosmos already uses to signal deprecated concepts (see specific comment on CSS file)
- The form has the text
* Value is required and can not be emptyat the bottom, but there are no asterisks next to the Subject and Message fields (or anywhere!). Could you please add asterisks after the labels to mark the required fields? - The default text "Write a subject" in the subject field looks the same as normal text entered into the field. This is a bit confusing, especially since the field will be considered empty for validation purposes even if the default text is there (see screenshot above). Could you please adjust the color/style of the default text so that it doesn't look like regular text, for example by making it a lighter shade?
I noticed that Bootstrap 3 (which Skosmos still uses) has special CSS classes for validation states and we could consider using them instead of a custom CSS class as is done here, but in practice, this would probably be more trouble than it's worth, as we would then have to override much of the Bootstrap styling anyway.
…border: 2px solid #D95F8A }. Contrast tests for text box with new border style passed (https://contrastchecker.com/). In the feedback form asterisk symbols added for required fields (subject and message)
There was a problem hiding this comment.
I tested this locally.
- Field outline color is now good!
- Asterisks are OK!
- The default text still looks too similar to user-entered text:
Can you please make the default text a lighter shade, so it doesn't look like the user has actually entered e.g. "Write a subject" into the subject field?
…ighter; and font-style: italic;
|
Kudos, SonarCloud Quality Gate passed!
|
|
Placeholder texts in the input fields are now lighter and italic |
miguelvaara
deleted the
issue1093-feedback-form-should-have-a-headline_or_subject
branch
A validation improved (solid red lines around the text fields in all validated and failed cases). In addition, WCAG 2.1 AA level related global style definition for HTML label tag now applies only to feedback form