Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed the description of search parameter maxhits #1135

Merged
merged 1 commit into from
Mar 11, 2021
Merged

Changed the description of search parameter maxhits #1135

merged 1 commit into from
Mar 11, 2021

Conversation

joelit
Copy link
Contributor

@joelit joelit commented Mar 11, 2021 •
edited by kouralex
Loading

Fixes #1112

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Mar 11, 2021 •
edited
Loading

Codecov Report

Merging #1135 (2a00943) into master (a201ace) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1135   +/-   ##
=========================================
  Coverage     67.90%   67.90%           
  Complexity     1583     1583           
=========================================
  Files            32       32           
  Lines          3889     3889           
=========================================
  Hits           2641     2641           
  Misses         1248     1248

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a201ace...2a00943. Read the comment docs.

osma
osma approved these changes Mar 11, 2021
View reviewed changes
Copy link
Member

@osma osma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! +1 for merging.

@osma osma merged commit 81d3633 into master Mar 11, 2021
@osma osma deleted the issue1112-maxhits branch March 11, 2021 11:47
@osma osma added this to the 2.10 milestone Mar 11, 2021
@osma osma added the bug label Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osma osma osma approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.10
Development

Successfully merging this pull request may close these issues.

REST: incorrect swagger.json description for maxhits parameter
2 participants
@joelit @osma