-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare code for jQuery 3.x #1144
Conversation
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #1144 +/- ##
=========================================
Coverage 67.96% 67.96%
Complexity 1584 1584
=========================================
Files 32 32
Lines 3889 3889
=========================================
Hits 2643 2643
Misses 1246 1246 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So many tags without closing 😄 . Looks good to me!
Tested with Docker, loaded the two vocabularies for the test, successfully navigated the UI, used the search dropdown, changed language. No issues found.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me too!
Thank you for reviewing! :) |
This PR mitigates warnings related to jQuery 3.x upgrade that were encountered whilst testing the product with jQuery 3.6.0 and jQuery Migrate 3.3.2 plugin. Additionally, fixes some validator.w3.org warnings.
Next step: replace/upgrade libraries that depend on jQuery 2.x or cause hassle, list includes (but is not necessarily limited to):
Some of these "only" use deprecated features that are not per se dangerous and jQuery Migrate plugin (which restores old API) can be used in production for a while. See https://github.com/jquery/jquery-migrate/blob/main/warnings.md for more information.
Additional info: https://jquery.com/upgrade-guide/3.0/ and https://jquery.com/upgrade-guide/3.5/