Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup translation files and rename trans_script to compile-translations #1199

Merged
merged 3 commits into from
Sep 9, 2021

Conversation

osma
Copy link
Member

@osma osma commented Sep 8, 2021

There are 3 cleanup style changes to the translation files under resource/translations:

  1. Remove unnecessary .mo files (the real ones are under language specific directories)
  2. Remove an unnecessary execute bit on one of the .po files
  3. Rename the strangely named script trans_script to compile-translations to better reflect what it does

I don't expect 1. and 2. to be controversial at all, but 3 could be. Also need to update the wiki documentation on translations accordingly.

@osma osma added this to the 2.12 milestone Sep 8, 2021
@osma osma self-assigned this Sep 8, 2021
@codecov
Copy link

codecov bot commented Sep 8, 2021

Codecov Report

Merging #1199 (c858069) into master (7a570ff) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1199   +/-   ##
=========================================
  Coverage     68.71%   68.71%           
  Complexity     1598     1598           
=========================================
  Files            32       32           
  Lines          3929     3929           
=========================================
  Hits           2700     2700           
  Misses         1229     1229           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a570ff...c858069. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 8, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@osma osma merged commit e2f4079 into master Sep 9, 2021
@osma osma deleted the cleanup-mo-files branch September 9, 2021 12:09
@osma
Copy link
Member Author

osma commented Sep 9, 2021

Merged the changes to master and updated the Translations wiki page accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant