-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom labels and tooltips for properties in concept view #1244
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1244 +/- ##
============================================
+ Coverage 69.07% 69.25% +0.18%
- Complexity 1638 1646 +8
============================================
Files 32 32
Lines 4016 4040 +24
============================================
+ Hits 2774 2798 +24
Misses 1242 1242
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general, though I have some concerns in the comment.
I will see if I can fix those and then test to see if this can be merged.
@@ -71,7 +73,6 @@ public function getPluginArray() : array | |||
|
|||
/** | |||
* Sets array of parameterized plugins | |||
* @param Easyrdf\Resource $pluginResource |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't relevant to the PR, but OK, it's a valid docstring fix.
…ently of each other
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the problems I saw, I think this is now good enough for merging.
Reasons for creating this PR
There was a need for renaming property labels in concept view for certain controlled vocabularies (metatietosanasto, kanto) and classifications. These do not strictly follow the normally assumed naming conventions for the concept properties.
Link to relevant issue(s), if any
Description of the changes in this PR
config.ttl
config.ttl
Known problems or uncertainties in this PR
Haven't tested if it's possible to create just new tooltips for existing property labels
Checklist